From: Dmitry Osipenko <digetx@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>,
mchehab@kernel.org, gregkh@linuxfoundation.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
hverkuil-cisco@xs4all.nl
Cc: linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend/resume as __maybe_unused
Date: Tue, 4 Aug 2020 08:58:22 +0300 [thread overview]
Message-ID: <709889ed-7757-ab5b-53c9-a061ae062d08@gmail.com> (raw)
In-Reply-To: <20200804014137.45444-1-yuehaibing@huawei.com>
04.08.2020 04:41, YueHaibing пишет:
> If CONFIG_PM is not set, gcc warns:
>
> drivers/staging/media/tegra-vde/vde.c:916:12:
> warning: 'tegra_vde_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it __maybe_unused to fix this.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: both suspend and resume functions marked
> ---
> drivers/staging/media/tegra-vde/vde.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c
> index a3c24d96d5b9..28845b5bafaf 100644
> --- a/drivers/staging/media/tegra-vde/vde.c
> +++ b/drivers/staging/media/tegra-vde/vde.c
> @@ -913,7 +913,7 @@ static irqreturn_t tegra_vde_isr(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static int tegra_vde_runtime_suspend(struct device *dev)
> +static __maybe_unused int tegra_vde_runtime_suspend(struct device *dev)
> {
> struct tegra_vde *vde = dev_get_drvdata(dev);
> int err;
> @@ -929,7 +929,7 @@ static int tegra_vde_runtime_suspend(struct device *dev)
> return 0;
> }
>
> -static int tegra_vde_runtime_resume(struct device *dev)
> +static __maybe_unused int tegra_vde_runtime_resume(struct device *dev)
> {
> struct tegra_vde *vde = dev_get_drvdata(dev);
> int err;
>
Thanks!
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
prev parent reply other threads:[~2020-08-04 5:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 11:59 [PATCH -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend as __maybe_unused YueHaibing
2020-08-03 12:51 ` Dmitry Osipenko
2020-08-03 13:00 ` Yuehaibing
2020-08-03 14:11 ` Dmitry Osipenko
2020-08-04 1:39 ` Yuehaibing
2020-08-04 1:41 ` [PATCH v2 -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend/resume " YueHaibing
2020-08-04 5:58 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=709889ed-7757-ab5b-53c9-a061ae062d08@gmail.com \
--to=digetx@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).