From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC371C7618A for ; Thu, 16 Mar 2023 09:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbjCPJcQ (ORCPT ); Thu, 16 Mar 2023 05:32:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbjCPJcO (ORCPT ); Thu, 16 Mar 2023 05:32:14 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E49F4B370A; Thu, 16 Mar 2023 02:32:12 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 02F89219ED; Thu, 16 Mar 2023 09:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678959131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgQ6KC2ybaQuhcxvNbj5yWV84Hdg07Eok3qBPbbxY94=; b=hSKEhyQb/6Qjn+ILebTCLmhg2e9A8CfNry1H0RTT8RjbcX0ewBMRxjmDEGJwKXajwe5mAZ lf5+kWSjWH3ALiTHhvLMzHP1U3K6ssM3drv98CuVfHI8RbC/TZ34ZdD7AfpSs1PrwdoY5A pI0L7xCe/IZAfteZaaDtgdTGWm9XBqE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678959131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgQ6KC2ybaQuhcxvNbj5yWV84Hdg07Eok3qBPbbxY94=; b=0yC+ZFrSFabuSowZtdH2oq1j4t0E9INETd9hrlrihhJEg9KK7ZdJaPl82UJ4mDZM/+qCvP EibyFzdcMAa1+2Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE806133E0; Thu, 16 Mar 2023 09:32:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9o+MNRjiEmRkRAAAMHmgww (envelope-from ); Thu, 16 Mar 2023 09:32:08 +0000 Date: Thu, 16 Mar 2023 10:32:08 +0100 Message-ID: <87ttylhwiv.wl-tiwai@suse.de> From: Takashi Iwai To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , V sujith kumar Reddy , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Gaosheng Cui , Thierry Reding , Jonathan Hunter , Mohan Kumar , Geoff Levand , Takashi Sakamoto , Michael Ellerman , Charles Keepax , Vijendar Mukunda , syed saba kareem , Mario Limonciello , Meng Tang , Martin =?ISO-8859-2?Q?Povi=B9er?= , Codrin Ciubotariu , Peter Rosin , Ray Jui , Scott Branden , Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , Alexander Sverdlin , Kuninori Morimoto , Richard Fitzgerald , James Schulman , David Rhodes , Lucas Tanure , Srinivas Kandagatla , Banajit Goswami , Miaoqian Lin , Colin Ian King , Aidan MacDonald , Zhang Qilong , Marek Szyprowski , Liang He , Shengjiu Wang , Xiubo Li , Shawn Guo , Sascha Hauer , Yang Yingliang , Minghao Chi , Kai Vehmanen , Bard Liao , Pierre-Louis Bossart , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Ranjani Sridharan , Akihiko Odaki , Amadeusz =?ISO-8859-2?Q?S=B3awi=F1ski?= , Andy Shevchenko , Hans de Goede , Moises Cardona , Zhen Ni , Mauro Carvalho Chehab , Andrey Turkin , Muralidhar Reddy , Zhu Ning , Gongjun Song , Shuming Fan , Yong Zhi , Lior Amsalem , Andrew Lunn , Hezi Shahmoon , Neta Zur Hershkovits , Marcin Wojtas , Matthias Brugger , Jiasheng Jiang , Ricardo Ribalda , Trevor Wu , Dan Carpenter , Jerome Brunet , Neil Armstrong , Kevin Hilman , Heiko Stuebner , Nicolas Frattaroli , Krzysztof Kozlowski , Sylwester Nawrocki , Linh Phung , Shang XiaoJing , Lad Prabhakar , Biju Das , Orson Zhai , Baolin Wang , Chunyan Zhang , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Mikhail Rudenko , Li Chen , Ban Tao , Sameer Pujar , YueHaibing , Jiapeng Chong , Li kunyu , Peter Ujfalusi , Jarkko Nikula , Kunihiko Hayashi , Masami Hiramatsu , Christophe JAILLET , Arnd Bergmann , Linus Walleij , Michal Simek , Max Filippov , alsa-devel@alsa-project.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, asahi@lists.linux.dev, Broadcom internal kernel review list , patches@opensource.cirrus.com, Fabio Estevam , Nicolin Chen , NXP Linux Team , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, 15 Mar 2023 16:04:52 +0100, Uwe Kleine-König wrote: > > Hello, > > this series adapts the platform drivers below sound/ to use the .remove_new() > callback. Compared to the traditional .remove() callback .remove_new() returns > no value. This is a good thing because the driver core doesn't (and cannot) > cope for errors during remove. The only effect of a non-zero return value in > .remove() is that the driver core emits a warning. The device is removed anyhow > and an early return from .remove() usually yields a resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > The first two patches simplify a driver each to return zero unconditionally, > and then all drivers are trivially converted to .remove_new(). > > There are nearly no interdependencies in this patch set---only 1 <- 11 and > 2 <- 16. So even if some individual problems are found (I don't expect that), > the other patches can (and from my POV should) still be applied. > > Best regards > Uwe > > Uwe Kleine-König (173): (snip) For the whole series, Acked-by: Takashi Iwai thanks, Takashi