From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EBBEB64DD for ; Thu, 29 Jun 2023 10:22:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbjF2KWg convert rfc822-to-8bit (ORCPT ); Thu, 29 Jun 2023 06:22:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231281AbjF2KWe (ORCPT ); Thu, 29 Jun 2023 06:22:34 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1624C187 for ; Thu, 29 Jun 2023 03:22:31 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-156-pPX-EROVOembC7vWITh1PA-1; Thu, 29 Jun 2023 11:22:15 +0100 X-MC-Unique: pPX-EROVOembC7vWITh1PA-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 29 Jun 2023 11:21:06 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Thu, 29 Jun 2023 11:21:06 +0100 From: David Laight To: 'Mark Brown' CC: 'Sameer Pujar' , "robh+dt@kernel.org" , "krzk+dt@kernel.org" , "thierry.reding@gmail.com" , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "jonathanh@nvidia.com" , "mkumard@nvidia.com" , "sheetal@nvidia.com" , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Oder Chiou Subject: RE: [PATCH v2 3/5] ASoC: rt5640: Fix sleep in atomic context Thread-Topic: [PATCH v2 3/5] ASoC: rt5640: Fix sleep in atomic context Thread-Index: AQHZqkh8hA8hSCOxA0KruUap8XcLma+hdFowgAAKboCAABMH0A== Date: Thu, 29 Jun 2023 10:21:06 +0000 Message-ID: <953c899d04e543f681e44daad4ec2ff7@AcuMS.aculab.com> References: <1688015537-31682-1-git-send-email-spujar@nvidia.com> <1688015537-31682-4-git-send-email-spujar@nvidia.com> <550e5c8f-0bfb-4ffc-9a43-1ecb153c6a02@sirena.org.uk> In-Reply-To: <550e5c8f-0bfb-4ffc-9a43-1ecb153c6a02@sirena.org.uk> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Mark Brown > Sent: 29 June 2023 11:11 > > On Thu, Jun 29, 2023 at 08:38:09AM +0000, David Laight wrote: > > From: Sameer Pujar > > > > Following prints are observed while testing audio on Jetson AGX Orin which > > > has onboard RT5640 audio codec: > > > > > > BUG: sleeping function called from invalid context at kernel/workqueue.c:3027 > > > in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0 > > > My 'gut feel' is that this will just move the problem elsewhere. > > > If the ISR is responsible for adding audio buffers (etc) then it is > > also not unlikely that the scheduling delays in running a threaded ISR > > will cause audio glitches if the system is busy. > > What makes you think this is anything to do with audio glitches? The > bug is literally what is described, it is not valid to sleep in atomic > contexts and if we ever actually try things are likely to go badly. What I mean is that deferring the ISR to process context is likely to generate audio glitches on a busy system. I realise that sleeping in an ISR goes badly wrong. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)