From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Krzysztof Kozlowski <krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
arm-soc <arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
SoC Team <soc-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Markus Mayer <mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
bcm-kernel-feedback-list
<bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Santosh Shilimkar
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jonathan Hunter
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux ARM
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-omap
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>"open
list:TEGRA ARCHITECTURE SUPPORT" <li>
Subject: Re: [PATCH 19/23] memory: omap-gpmc: Enclose macro statements in do-while
Date: Thu, 23 Jul 2020 11:09:40 +0200 [thread overview]
Message-ID: <CAK8P3a3emZd=Tz5JhxevkX3OJMMEn_2Nb+_LQtGZJ9-GWNpd2g@mail.gmail.com> (raw)
In-Reply-To: <20200723073744.13400-20-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski <krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>
> do-while is a preferred way for complex macros because of safety
> reasons. This fixes checkpatch error:
>
> ERROR: Macros starting with if should be enclosed by a do - while
> loop to avoid possible if/else logic defects
>
> Signed-off-by: Krzysztof Kozlowski <krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
This is an improvement, but the macro still has other issues that
are just as bad as the one you address:
- Using the # operator to avoid the "" in the invocation seems confusing
- it implicitly uses the 'cs' and 't' variables of the calling function instead
of passing them as arguments.
- it calls 'return -1' in a function that otherwise uses errno-style
return codes, so this gets interpreted as EPERM "Operation not
permitted".
I would probably just open-code the entire thing and remove the
macro like:
ret = 0;
ret |= set_gpmc_timing_reg(cs, GPMC_CS_CONFIG2, 0, 3, 0, t->cs_on,
GPMC_CD_FCLK, "cs_on");
ret |= set_gpmc_timing_reg(cs, GPMC_CS_CONFIG2, 8, 12, 0,
t->cs_rd_off, GPMC_CD_FCLK, "cs_rd_off");
ret |= set_gpmc_timing_reg(cs, GPMC_CS_CONFIG2, 16, 20, 0,
t->cs_wr_off, GPMC_CD_FCLK, "cs_wr_off);
...
if (ret)
return -ENXIO;
Of maybe leave the macro, but remove the if/return part and use
the "ret |= GPMC_SET_ONE(...)" trick to avoid some of the problems.
Arnd
next prev parent reply other threads:[~2020-07-23 9:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200723073744.13400-1-krzk@kernel.org>
[not found] ` <20200723073744.13400-15-krzk@kernel.org>
[not found] ` <20200723073744.13400-15-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-07-23 8:48 ` [PATCH 14/23] memory: ti-emif-pm: Fix cast to iomem pointer Arnd Bergmann
[not found] ` <CAK8P3a3btGD5oqmPXJk=UOmA=wuUxn-vOOO982uAjuRcE3crVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-23 9:02 ` Krzysztof Kozlowski
2020-07-23 9:14 ` Arnd Bergmann
[not found] ` <CAK8P3a2O4bCb_Bcpc+Y4BuXmrO6mbVwgo67aGF5E=uxHQpeTnw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-23 10:01 ` Krzysztof Kozlowski
[not found] ` <20200723073744.13400-19-krzk@kernel.org>
[not found] ` <20200723073744.13400-19-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-07-23 8:50 ` [PATCH 18/23] memory: mtk-smi: Add argument to function definition Arnd Bergmann
2020-07-23 8:55 ` Krzysztof Kozlowski
[not found] ` <20200723073744.13400-20-krzk@kernel.org>
[not found] ` <20200723073744.13400-20-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-07-23 9:09 ` Arnd Bergmann [this message]
2020-07-23 10:16 ` [PATCH 19/23] memory: omap-gpmc: Enclose macro statements in do-while Krzysztof Kozlowski
[not found] ` <20200723073744.13400-21-krzk@kernel.org>
[not found] ` <20200723073744.13400-21-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-07-23 9:11 ` [PATCH 20/23] memory: omap-gpmc: Fix whitespace issue Arnd Bergmann
[not found] ` <CAK8P3a1=WCQ5326Et5RRK7yiOYeHH7uUkQ+T3YPtj2XRh+gkgA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-23 10:08 ` Krzysztof Kozlowski
[not found] ` <20200723073744.13400-1-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-07-23 9:31 ` [RFC PATCH 00/23] memory: Cleanup, improve and compile test memory drivers Arnd Bergmann
[not found] ` <CAK8P3a0hcVhBbKCBDSZYXChmPpRVsEi_G6+oj5quC6uUiPeeiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-23 9:52 ` Krzysztof Kozlowski
2020-07-23 10:14 ` Arnd Bergmann
[not found] ` <20200723073744.13400-17-krzk@kernel.org>
[not found] ` <20200723073744.13400-17-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-07-23 17:11 ` [PATCH 16/23] memory: brcmstb_dpfe: Constify the contents of string Florian Fainelli
2020-07-23 17:15 ` Markus Mayer
[not found] ` <20200723073744.13400-18-krzk@kernel.org>
2020-07-23 17:11 ` [PATCH 17/23] memory: brcmstb_dpfe: Remove unneeded braces Florian Fainelli
[not found] ` <e65d4ed3-3c01-acb7-f324-be99201815df-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-23 17:15 ` Markus Mayer
[not found] ` <20200723073744.13400-24-krzk@kernel.org>
2020-07-23 17:12 ` [PATCH 23/23] MAINTAINERS: Add Krzysztof Kozlowski as maintainer of memory controllers Florian Fainelli
2020-07-24 7:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3emZd=Tz5JhxevkX3OJMMEn_2Nb+_LQtGZJ9-GWNpd2g@mail.gmail.com' \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=rogerq-l0cyMroinI0@public.gmane.org \
--cc=soc-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).