From: Thierry Reding <thierry.reding@gmail.com>
To: Brad Griffis <bgriffis@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity
Date: Fri, 21 Jul 2023 08:21:44 +0200 [thread overview]
Message-ID: <ZLoj-JgLqL619m70@orome> (raw)
In-Reply-To: <20230626180920.318774-1-bgriffis@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]
On Mon, Jun 26, 2023 at 06:09:19PM +0000, Brad Griffis wrote:
> The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low.
>
> Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
> Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This DTS include is also used by Jetson Orin NX, but I assume that the
same polarity applies to that as well?
Actually, looking at the Orin NX, I don't see an SD card slot and
judging by the documentation that I was able to find it's not documented
for Orin Nano either. Or is it only certain variants that were equipped
with the SD slot?
Thierry
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> index bd60478fa75e..831a553ec387 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi
> @@ -42,7 +42,7 @@ flash@0 {
> mmc@3400000 {
> status = "okay";
> bus-width = <4>;
> - cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_HIGH>;
> + cd-gpios = <&gpio TEGRA234_MAIN_GPIO(G, 7) GPIO_ACTIVE_LOW>;
> disable-wp;
> };
>
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-21 6:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 18:09 [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity Brad Griffis
2023-06-26 18:09 ` [PATCH 2/2] arm64: tegra: fix p3767 QSPI speed Brad Griffis
2023-07-21 6:26 ` Thierry Reding
2023-08-15 13:38 ` Brad Griffis
2023-08-16 16:17 ` Thierry Reding
2023-07-21 6:21 ` Thierry Reding [this message]
2023-08-15 13:37 ` [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity Brad Griffis
2023-08-16 16:18 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLoj-JgLqL619m70@orome \
--to=thierry.reding@gmail.com \
--cc=bgriffis@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).