From: Sameer Pujar <spujar@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>,
<kuninori.morimoto.gx@renesas.com>,
<pierre-louis.bossart@linux.intel.com>, <perex@perex.cz>,
<tiwai@suse.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
<atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
<swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: [PATCH v3 09/13] ASoC: dt-bindings: tegra: Add schema for audio graph card
Date: Fri, 16 Oct 2020 10:44:15 +0530 [thread overview]
Message-ID: <acbcd136-a933-e5e0-863b-f435dafe1697@nvidia.com> (raw)
In-Reply-To: <a5bc07d8-fb2e-e86e-f0d3-be19166ad7bb@nvidia.com>
>>> Add YAML schema for Tegra audio graph sound card DT bindings. It
>>> uses the
>>> same DT bindings provided by generic audio graph driver. Along with
>>> this
>>> few standard clock DT bindings are added which are specifically
>>> required
>>> for Tegra audio.
>>>
>>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>>> ---
>>> .../sound/nvidia,tegra-audio-graph-card.yaml | 70
>>> ++++++++++++++++++++++
>>> 1 file changed, 70 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
>>> b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
>>>
>>> new file mode 100644
>>> index 0000000..b73fbe5
>>> --- /dev/null
>>> +++
>>> b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
>>> @@ -0,0 +1,70 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id:
>>> http://devicetree.org/schemas/sound/nvidia,tegra-audio-graph-card.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Audio Graph based Tegra sound card driver
>>> +
>>> +description: |
>>> + This is based on generic audio graph card driver along with
>>> additional
>>> + customizations for Tegra platforms. It uses the same bindings with
>>> + additional standard clock DT bindings required for Tegra.
>>> +
>>> +
>>> See{LINUX}/Documentation/devicetree/bindings/sound/audio-graph-card.txt
>>> +
>>> +maintainers:
>>> + - Jon Hunter <jonathanh@nvidia.com>
>>> + - Sameer Pujar <spujar@nvidia.com>
>>> +
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - const: nvidia,tegra210-audio-graph-card
>>> + - const: nvidia,tegra186-audio-graph-card
>>> +
>>> + clocks:
>>> + minItems: 2
>>> +
>>> + clock-names:
>>> + minItems: 2
>>> + items:
>>> + - const: pll_a
>>> + - const: plla_out0
>>> +
>>> + assigned-clocks:
>>> + minItems: 1
>>> + maxItems: 3
>>> +
>>> + assigned-clock-parents:
>>> + minItems: 1
>>> + maxItems: 3
>>> +
>>> + assigned-clock-rates:
>>> + minItems: 1
>>> + maxItems: 3
>>> +
>>> +required:
>>> + - compatible
>>> + - clocks
>>> + - clock-names
>>> + - assigned-clocks
>>> + - assigned-clock-parents
>> Where's the graph? You need to define the ports and reference the common
>> schema.
>
> I am looking to reference the bindings used in below doc which is not
> yet in YAML format. Only additional properties I listed here.
> {LINUX}/Documentation/devicetree/bindings/sound/audio-graph-card.txt
>
> Should I keep this doc to *.txt format as well and later move to YAML
> or is there a way to reference *.txt doc here?
The dependency here is like below,
Tegra audio graph card -> generic audio graph card
(audio-graph-card.txt) -> graph (graph.txt)
I plan to convert dependencies to json-schema in next revision and then
refer these for Tegra audio graph card.
next prev parent reply other threads:[~2020-10-16 5:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 17:32 [PATCH v3 00/13] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 01/13] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-10-01 18:53 ` Michał Mirosław
2020-10-02 8:50 ` Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 02/13] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 03/13] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 04/13] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 05/13] ASoC: audio-graph: Support empty Codec endpoint Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 06/13] ASoC: simple-card-utils: Expose new members for asoc_simple_priv Sameer Pujar
2020-10-02 1:45 ` Kuninori Morimoto
2020-10-02 8:59 ` Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 07/13] ASoC: audio-graph: Update driver as per new exposed members Sameer Pujar
2020-10-02 1:46 ` Kuninori Morimoto
2020-10-02 9:00 ` Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 08/13] ASoC: audio-graph: Expose helpers from audio graph Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 09/13] ASoC: dt-bindings: tegra: Add schema for audio graph card Sameer Pujar
2020-10-06 20:34 ` Rob Herring
2020-10-07 7:13 ` Sameer Pujar
2020-10-16 5:14 ` Sameer Pujar [this message]
2020-10-16 16:42 ` Mark Brown
2020-10-01 17:33 ` [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver Sameer Pujar
2020-10-01 19:07 ` Michał Mirosław
2020-10-01 19:44 ` Jon Hunter
2020-10-01 20:57 ` Dmitry Osipenko
2020-10-01 21:02 ` Dmitry Osipenko
2020-10-02 8:51 ` Sameer Pujar
2020-10-02 5:34 ` Kuninori Morimoto
2020-10-02 9:08 ` Sameer Pujar
2020-10-04 23:20 ` Kuninori Morimoto
2020-10-01 17:33 ` [PATCH v3 11/13] arm64: defconfig: Enable Tegra audio graph " Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 12/13] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 13/13] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acbcd136-a933-e5e0-863b-f435dafe1697@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=nicoleotsuka@gmail.com \
--cc=nwartikar@nvidia.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rlokhande@nvidia.com \
--cc=robh@kernel.org \
--cc=sharadg@nvidia.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).