From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E13D8C433DF for ; Fri, 24 Jul 2020 16:33:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A76D206D8 for ; Fri, 24 Jul 2020 16:33:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="lU1h2ZkC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbgGXQd1 (ORCPT ); Fri, 24 Jul 2020 12:33:27 -0400 Received: from mout02.posteo.de ([185.67.36.66]:53095 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgGXQd1 (ORCPT ); Fri, 24 Jul 2020 12:33:27 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 201572400FE for ; Fri, 24 Jul 2020 18:33:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1595608404; bh=0gYLUq/Mn2wAVjYBymteJJm8c1Ixey3paEl6GWCDEmc=; h=Date:From:To:cc:Subject:From; b=lU1h2ZkCjbiPJxWBp42aBjdYM3vJeGyHQxF/5eStrbfDD3CQak5To6HudgNCnFsCO X0LA4HO91Msb9PDLmNpaLg7ZhStKMpdndpxrk7whrahoeuKBCoD/mvD6ldCRmRJkn6 4O/SGbu4sGDbFBwFdFd6O8h7vczQv/8dVR0B0Pdx5xVKANzycDTySqsjmtFP9/LQPP fS8LTRB7MCWgwL/IAqFSeCbqoqQ0dm/XA0P23SWWFnqwGXCjzJ9ASa/pzV2dzBa7kt dLndy40RKMicX9pzcFTnPczcOlehRCU8BDph06g+SNkh7oCo4AXebqnegbH5+Pg3pG Yenp1pfl9yNnQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BCvrz03p6z9rxP; Fri, 24 Jul 2020 18:33:22 +0200 (CEST) Date: Fri, 24 Jul 2020 18:33:22 +0200 (CEST) From: Marc Dietrich X-X-Sender: lucile@macbook-pro.fritz.box To: Rohit Bharadwaj cc: Greg KH , p.zabel@pengutronix.de, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, ac100@lists.launchpad.net Subject: Re: [PATCH v3] staging: nvec: change usage of slave to secondary In-Reply-To: <34e6c906-7def-816d-a45d-03d366f32c61@gmail.com> Message-ID: References: <20200723151511.22193-1-bharadwaj.rohit8@gmail.com> <20200724043633.7755-1-bharadwaj.rohit8@gmail.com> <20200724082810.GA3977020@kroah.com> <34e6c906-7def-816d-a45d-03d366f32c61@gmail.com> User-Agent: Alpine 2.23 (OSX 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi Rohit, On Fri, 24 Jul 2020, Rohit Bharadwaj wrote: > On 24/07/20 1:58 pm, Greg KH wrote: >> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote: >>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote: >>>> changed usage of slave (deprecated) to secondary >>>> >>>> Signed-off-by: Rohit K Bharadwaj >>>> --- >>>> v3: change patch subject, add version history >>>> v2: add changelog text in body of mail >>>> v1: fix style issues by changing usage of slave to secondary >>>> >>>> drivers/staging/nvec/nvec.c | 12 ++++++------ >>>> 1 file changed, 6 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c >>>> index 360ec0407740..5d7b66719a39 100644 >>>> --- a/drivers/staging/nvec/nvec.c >>>> +++ b/drivers/staging/nvec/nvec.c >>>> @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) >>>> return IRQ_HANDLED; >>>> } >>>> >>>> -static void tegra_init_i2c_slave(struct nvec_chip *nvec) >>>> +static void tegra_init_i2c_secondary(struct nvec_chip *nvec) >>>> { >>>> u32 val; >>>> >>>> @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) >>>> } >>>> >>>> #ifdef CONFIG_PM_SLEEP >>>> -static void nvec_disable_i2c_slave(struct nvec_chip *nvec) >>>> +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec) >>>> { >>>> disable_irq(nvec->irq); >>>> writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG); >>>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) >>>> platform_set_drvdata(pdev, nvec); >>>> nvec->dev = dev; >>>> >>>> - if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) { >>>> + if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) { >>>> dev_err(dev, "no i2c address specified"); >>>> return -ENODEV; >>>> } as Christoph said, please don't change this line. >>>> @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) >>>> } >>>> disable_irq(nvec->irq); >>>> >>>> - tegra_init_i2c_slave(nvec); >>>> + tegra_init_i2c_secondary(nvec); >>>> >>>> /* enable event reporting */ >>>> nvec_toggle_global_events(nvec, true); >>>> @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev) >>>> if (!err) >>>> nvec_msg_free(nvec, msg); >>>> >>>> - nvec_disable_i2c_slave(nvec); >>>> + nvec_disable_i2c_secondary(nvec); >>>> >>>> return 0; >>>> } >>>> @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev) >>>> struct nvec_chip *nvec = dev_get_drvdata(dev); >>>> >>>> dev_dbg(nvec->dev, "resuming\n"); >>>> - tegra_init_i2c_slave(nvec); >>>> + tegra_init_i2c_secondary(nvec); >>>> nvec_toggle_global_events(nvec, true); >>>> >>>> return 0; >>>> >>> Dear All, this message was not delivered to marvin24@gmx.de, I'm getting that The response from the remote server was: >>> 554 gmx.net (mxgmx016) Nemesis ESMTP Service not available No SMTP service Reject due to policy restrictions, >> >> Not a big deal, email address atrophy over time. That's why you always >> cc: a public mailing list for patches. yes, my mail provider introduces a bit too aggressive mail filtering recently, causing me being unsubscribed frequently. I just changed my subscriber address, which should fix the problem, sorry. Marc