From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05163C433E0 for ; Sun, 2 Aug 2020 08:07:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEF572075A for ; Sun, 2 Aug 2020 08:07:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="nAaJczvc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725854AbgHBIHZ (ORCPT ); Sun, 2 Aug 2020 04:07:25 -0400 Received: from mout02.posteo.de ([185.67.36.66]:38201 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbgHBIHZ (ORCPT ); Sun, 2 Aug 2020 04:07:25 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 324CF2400FC for ; Sun, 2 Aug 2020 10:07:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1596355642; bh=86Z4B7YUBM0X0IAjeyX3W7qBbGjRKRNDaWib5h7AxFU=; h=Date:From:To:cc:Subject:From; b=nAaJczvcBTNDT9PQPb1zkCv7ppenrnsc9w+6DIC5IxpNSYpLdiWA/IIq4cwGiUKEK w4r/5njxcII552dLzSOI30gxlwXe3QOSF/QXluIs94bQfjDNax+MXMeeiK+aqX4Rsx b1lsB9zRwKEycgg+MFIGd042FD+EaFVFTfgeUl7GQHcbxvV+/9A77Mqitq6Ukk0ZfD /bMngq2VKQuzvTSaWpi1Kch+rfFJSdPp0kLHT4/s0fNxgsgxvgdfEghXabKzsU859n +7AtLcRse7oyoghWg3KTLvGRtfoLYl06HIAFoN8044Z/UM2X1Ma1sj1s/MTggWWSFB nLWO5t+zdGVQw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BKDBw6l1zz9rxW; Sun, 2 Aug 2020 10:07:20 +0200 (CEST) Date: Sun, 2 Aug 2020 10:07:20 +0200 (CEST) From: Marc Dietrich X-X-Sender: lucile@macbook-pro.fritz.box To: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= cc: Rohit K Bharadwaj , marvin24@posteo.de, gregkh@linuxfoundation.org, p.zabel@pengutronix.de, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, Dan Carpenter Subject: Re: [PATCH v4] staging: nvec: change usage of slave to secondary In-Reply-To: <20200725125054.GB18633@qmqm.qmqm.pl> Message-ID: References: <20200724043633.7755-1-bharadwaj.rohit8@gmail.com> <20200725062938.15388-1-bharadwaj.rohit8@gmail.com> <20200725120146.GB26689@qmqm.qmqm.pl> <5597e949-b93c-9133-efdb-9714637f9ebc@gmail.com> <20200725125054.GB18633@qmqm.qmqm.pl> User-Agent: Alpine 2.23 (OSX 453 2020-06-18) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-1827979472-1596355641=:41131" Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1827979472-1596355641=:41131 Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 8BIT Hi, On Sat, 25 Jul 2020, Michał Mirosław wrote: > On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote: >> On 25/07/20 5:31 pm, Michał Mirosław wrote: >>> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: >>>> changed usage of slave (which is deprecated) to secondary without breaking the driver >>> >>> The relevant I2C and SMBus standards use master/slave terminology. Why are >>> you changing the names to something unfamiliar? >>> >>> If the reason are the recent coding-style changes, then please note they >>> are about avoiding introducing *NEW* uses of the specific words and not >>> about blindly replacing existing occurrences. >> >> I'm really sorry sir, I didn't knew about this, yes the reason for my change is according to the script checkpatch.pl to suit the coding style, I would try to fix some other coding style related issues if this patch seems to be a bad idea. > > I didn't know checkpatch does this (it doesn't in current Linus' master > tree). I can see there is a commit in next adding this, but seems that > it uses a test far from the original coding-style wording... given the discussion here [1] and also looking at the coding style patch here [2], I think this patch should not be applied. The slave term here comes from the I2C protocol (which we can't change) which is listed as an exception in [2], see below: "+Exceptions for introducing new usage is to maintain a userspace ABI/API, +or when updating code for an existing (as of 2020) hardware or protocol +specification that mandates those terms. For new specifications +translate specification usage of the terminology to the kernel coding +standard where possible. " Marc [1] https://lkml.org/lkml/2020/6/11/60 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Documentation/process/coding-style.rst?id=a5f526ec --0-1827979472-1596355641=:41131--