From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Maxime Ripard <mripard@kernel.org>,
Dmitry Osipenko <digetx@gmail.com>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] clk: tegra: Avoid calling an uninitialized function
Date: Tue, 04 Jul 2023 08:54:50 -0700 [thread overview]
Message-ID: <b3c1a754f350791da21c92356b2b497f.sboyd@kernel.org> (raw)
In-Reply-To: <20230630130748.840729-1-thierry.reding@gmail.com>
Quoting Thierry Reding (2023-06-30 06:07:48)
> From: Thierry Reding <treding@nvidia.com>
>
> Commit 493ffb046cf5 ("clk: tegra: super: Switch to determine_rate")
> replaced clk_super_round_rate() by clk_super_determine_rate(), but
> didn't update one callsite that was explicitly calling the old
> tegra_clk_super_ops.round_rate() function, which was now NULL. This
> resulted in a crash on Tegra30 systems during early boot.
>
> Switch this callsite over to the clk_super_determine_rate() equivalent
> to avoid the crash.
>
> Fixes: 493ffb046cf5 ("clk: tegra: super: Switch to determine_rate")
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2023-07-04 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 13:07 [PATCH] clk: tegra: Avoid calling an uninitialized function Thierry Reding
2023-07-04 15:54 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c1a754f350791da21c92356b2b497f.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).