From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC572C6FD19 for ; Mon, 13 Mar 2023 22:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbjCMWCU (ORCPT ); Mon, 13 Mar 2023 18:02:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbjCMWCT (ORCPT ); Mon, 13 Mar 2023 18:02:19 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8961FEE; Mon, 13 Mar 2023 15:01:44 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id 4so7692188ilz.6; Mon, 13 Mar 2023 15:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678744904; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=DMLvNFiF6A+cLlm+Md6S//7sOrhzSCiOnPwGbda9MTs=; b=aWXb3DK3A5HljkDmtHfJIax0Z4RexrlgcAXu6rc5w2LBmdFm0ZhzhLWq9rUOZmDdp2 qjfynGlY/ln39BF9ghwsOTTnx2ty5W57Izt1vktIL66IwFpZ/SXIeL7yDa5HJPkJlCYF NuKPKFxU3VSN9QKyNg+xaVoMZ5ANKIiFT49KWS508WvyJUv1PSNLqT36iEIBajXHYKM2 acqHQd4/vdBLJ+TdQuHL6ydeVF/R7kSdyCG95wHm3s6ebS7yK6DpiZc5sxZdrmyjrlR3 Jyx/d7UvLyTcSFtZrbuWKS9R4+hA1qJSfOEOf/z7YJ4IiYDiNLA5Q6zZJgMbK8TX/7NT YeRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678744904; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DMLvNFiF6A+cLlm+Md6S//7sOrhzSCiOnPwGbda9MTs=; b=fq9W17n7iQPdGzbrekDv31M02f35zOTNgukH/+gHFz6mHytG8BjUt1nkG3vaNFsRWj QlzyH8eN8LEZhKjj7b6baacMPhJAblUBj7D89L4JQIICRoEanH8fD1Yn7gbqnQo4+Mo0 0U1fjM2q0dHpLy+CkaWAnEjvzFx6aiMoMAcoNDjL4v0vdrLNOTD9F5XwtOCuPopAS2O/ rsjiN9ROnvB+TPGvoc2Xq6/DMpQkee6Ss5TiAC8MmwPHFxK317tfCLtP1dejIvoqjM3J JKkeCq/e1U3dMuXnUU7jXHHngwj478H0NAlNsTjBBkf5byabuEAPdiiqhMH9yey8re13 fPTQ== X-Gm-Message-State: AO0yUKUraGFq/4Z5jubfjer5ZuDRtOhhJKBzb1Ao3PENA6bNtTfuPGpW K7SZIyjht5nLmp0jNuU/7gA= X-Google-Smtp-Source: AK7set/CnpGrRNOlgdLP6A3PzpsbmZdrv5qoYIZVsXl6Lk7tiSYIV4Z0CbZ7o/CqEdQmrdQf0Yh05w== X-Received: by 2002:a05:6e02:dc1:b0:315:5467:4a3f with SMTP id l1-20020a056e020dc100b0031554674a3fmr720344ilj.30.1678744904090; Mon, 13 Mar 2023 15:01:44 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d19-20020a056e020bf300b00316e3a38becsm282388ilu.18.2023.03.13.15.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 15:01:43 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 13 Mar 2023 15:01:40 -0700 From: Guenter Roeck To: Krzysztof Kozlowski Cc: Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Manivannan Sadhasivam , Michael Tretter , Pengutronix Kernel Team , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Rui Miguel Silva , Wenyou Yang , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Patrice Chotard , Yong Deng , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Lad, Prabhakar" , Ezequiel Garcia , Philipp Zabel , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table Message-ID: References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). > > drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Guenter Roeck FWIW: There is also https://patches.linaro.org/project/linux-media/patch/20230215214724.3798917-1-linux@roeck-us.net/ The lack of ACPI support is a real problem and very relevant. Guenter > --- > drivers/media/cec/i2c/ch7322.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c > index 34fad7123704..3c6e6496a001 100644 > --- a/drivers/media/cec/i2c/ch7322.c > +++ b/drivers/media/cec/i2c/ch7322.c > @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match); > static struct i2c_driver ch7322_i2c_driver = { > .driver = { > .name = "ch7322", > - .of_match_table = of_match_ptr(ch7322_of_match), > + .of_match_table = ch7322_of_match, > }, > .probe_new = ch7322_probe, > .remove = ch7322_remove,