* Re: [PATCH -next] arm64: Export __cpu_logical_map [not found] ` <20200727160515.GA8003@bogus> @ 2020-08-01 12:16 ` Sumit Gupta 2020-08-10 7:49 ` Sudeep Holla 0 siblings, 1 reply; 5+ messages in thread From: Sumit Gupta @ 2020-08-01 12:16 UTC (permalink / raw) To: Sudeep Holla Cc: Kefeng Wang, Catalin Marinas, Will Deacon, Mikko Perttunen, Viresh Kumar, Hulk Robot, linux-kernel@vger.kernel.org List, linux-arm-kernel, Bibek Basu, Sumit Gupta, linux-tegra, Thierry Reding, Jon Hunter >>>>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! >>>>> >>>>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export >>>>> __cpu_logical_map to fix build issue. >>>>> >>> >>> I wonder why like other instances in the drivers, the mpidr is not get >>> directly from the cpu. The cpufreq_driver->init call happens when the cpu >>> is being brought online and is executed on the required cpu IIUC. >>> >> Yes, this occurs during hotplug case. >> But in the case of system boot, 'cpufreq_driver->init' is called later >> during cpufreq platform driver's probe. The value of CPU in 'policy->cpu' >> can be different from the current CPU. That's why read_cpuid_mpidr() can't >> be used. >> > > Fair enough, why not do cross call like in set_target ? Since it is one-off > in init, I don't see any issue when you are doing it runtime for set_target. > >>> read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map. >>> Though we may not add physical hotplug anytime soon, less dependency >>> on this cpu_logical_map is better given that we can resolve this without >>> the need to access the map. >>> > > To be honest, we have tried to remove all the dependency on cluster id > in generic code as it is not well defined. This one is tegra specific > driver so should be fine. But I am still bit nervous to export > cpu_logical_map as we have no clue what that would mean for physical > hotplug. > As suggested, I have done below change to get the cluster number using read_cpuid_mpidr(). Please review and suggest if this looks ok? I will send formal patch if the change is fine. Thanks, Sumit ---- diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c index bae527e..06f5ccf 100644 --- a/drivers/cpufreq/tegra194-cpufreq.c +++ b/drivers/cpufreq/tegra194-cpufreq.c @@ -56,9 +56,11 @@ struct read_counters_work { static struct workqueue_struct *read_counters_wq; -static enum cluster get_cpu_cluster(u8 cpu) +static void get_cpu_cluster(void *cluster) { - return MPIDR_AFFINITY_LEVEL(cpu_logical_map(cpu), 1); + u64 mpidr = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; + + *((uint32_t *) cluster) = MPIDR_AFFINITY_LEVEL(mpidr, 1); } /* @@ -186,8 +188,10 @@ static unsigned int tegra194_get_speed(u32 cpu) static int tegra194_cpufreq_init(struct cpufreq_policy *policy) { struct tegra194_cpufreq_data *data = cpufreq_get_driver_data(); - int cl = get_cpu_cluster(policy->cpu); u32 cpu; + u32 cl; + + smp_call_function_single(policy->cpu, get_cpu_cluster, &cl, true); > > -- > Regards, > Sudeep > ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] arm64: Export __cpu_logical_map 2020-08-01 12:16 ` [PATCH -next] arm64: Export __cpu_logical_map Sumit Gupta @ 2020-08-10 7:49 ` Sudeep Holla 2020-08-10 10:19 ` Catalin Marinas 0 siblings, 1 reply; 5+ messages in thread From: Sudeep Holla @ 2020-08-10 7:49 UTC (permalink / raw) To: Sumit Gupta Cc: Kefeng Wang, Catalin Marinas, Will Deacon, Mikko Perttunen, Viresh Kumar, Hulk Robot, linux-kernel@vger.kernel.org List, linux-arm-kernel, Bibek Basu, linux-tegra, Thierry Reding, Sudeep Holla, Jon Hunter On Sat, Aug 01, 2020 at 05:46:43PM +0530, Sumit Gupta wrote: > > > > > > > ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! > > > > > > > > > > > > ARM64 tegra194-cpufreq driver use cpu_logical_map, export > > > > > > __cpu_logical_map to fix build issue. > > > > > > > > > > > > > > I wonder why like other instances in the drivers, the mpidr is not get > > > > directly from the cpu. The cpufreq_driver->init call happens when the cpu > > > > is being brought online and is executed on the required cpu IIUC. > > > > > > > Yes, this occurs during hotplug case. > > > But in the case of system boot, 'cpufreq_driver->init' is called later > > > during cpufreq platform driver's probe. The value of CPU in 'policy->cpu' > > > can be different from the current CPU. That's why read_cpuid_mpidr() can't > > > be used. > > > > > > > Fair enough, why not do cross call like in set_target ? Since it is one-off > > in init, I don't see any issue when you are doing it runtime for set_target. > > > > > > read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map. > > > > Though we may not add physical hotplug anytime soon, less dependency > > > > on this cpu_logical_map is better given that we can resolve this without > > > > the need to access the map. > > > > > > > > To be honest, we have tried to remove all the dependency on cluster id > > in generic code as it is not well defined. This one is tegra specific > > driver so should be fine. But I am still bit nervous to export > > cpu_logical_map as we have no clue what that would mean for physical > > hotplug. > > > As suggested, I have done below change to get the cluster number using > read_cpuid_mpidr(). Please review and suggest if this looks ok? > I will send formal patch if the change is fine. > > Thanks, > Sumit > > ---- > > diff --git a/drivers/cpufreq/tegra194-cpufreq.c > b/drivers/cpufreq/tegra194-cpufreq.c > index bae527e..06f5ccf 100644 > --- a/drivers/cpufreq/tegra194-cpufreq.c > +++ b/drivers/cpufreq/tegra194-cpufreq.c > @@ -56,9 +56,11 @@ struct read_counters_work { > > static struct workqueue_struct *read_counters_wq; > > -static enum cluster get_cpu_cluster(u8 cpu) > +static void get_cpu_cluster(void *cluster) > { > - return MPIDR_AFFINITY_LEVEL(cpu_logical_map(cpu), 1); > + u64 mpidr = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > + > + *((uint32_t *) cluster) = MPIDR_AFFINITY_LEVEL(mpidr, 1); > } > > /* > @@ -186,8 +188,10 @@ static unsigned int tegra194_get_speed(u32 cpu) > static int tegra194_cpufreq_init(struct cpufreq_policy *policy) > { > struct tegra194_cpufreq_data *data = cpufreq_get_driver_data(); > - int cl = get_cpu_cluster(policy->cpu); > u32 cpu; > + u32 cl; > + > + smp_call_function_single(policy->cpu, get_cpu_cluster, &cl, true); Thanks for this, looks good to me. You can add: Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] arm64: Export __cpu_logical_map 2020-08-10 7:49 ` Sudeep Holla @ 2020-08-10 10:19 ` Catalin Marinas 2020-08-10 12:11 ` Sudeep Holla 2020-08-11 19:44 ` Sumit Gupta 0 siblings, 2 replies; 5+ messages in thread From: Catalin Marinas @ 2020-08-10 10:19 UTC (permalink / raw) To: Sudeep Holla Cc: Sumit Gupta, Kefeng Wang, Will Deacon, Mikko Perttunen, Viresh Kumar, Hulk Robot, linux-kernel@vger.kernel.org List, linux-arm-kernel, Bibek Basu, linux-tegra, Thierry Reding, Jon Hunter On Mon, Aug 10, 2020 at 08:49:56AM +0100, Sudeep Holla wrote: > On Sat, Aug 01, 2020 at 05:46:43PM +0530, Sumit Gupta wrote: > > > > > > > ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! > > > > > > > > > > > > > > ARM64 tegra194-cpufreq driver use cpu_logical_map, export > > > > > > > __cpu_logical_map to fix build issue. > > > > > > > > > > > > > > > > > I wonder why like other instances in the drivers, the mpidr is not get > > > > > directly from the cpu. The cpufreq_driver->init call happens when the cpu > > > > > is being brought online and is executed on the required cpu IIUC. > > > > > > > > Yes, this occurs during hotplug case. > > > > But in the case of system boot, 'cpufreq_driver->init' is called later > > > > during cpufreq platform driver's probe. The value of CPU in 'policy->cpu' > > > > can be different from the current CPU. That's why read_cpuid_mpidr() can't > > > > be used. > > > > > > Fair enough, why not do cross call like in set_target ? Since it is one-off > > > in init, I don't see any issue when you are doing it runtime for set_target. > > > > > > > > read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map. > > > > > Though we may not add physical hotplug anytime soon, less dependency > > > > > on this cpu_logical_map is better given that we can resolve this without > > > > > the need to access the map. > > > > > > To be honest, we have tried to remove all the dependency on cluster id > > > in generic code as it is not well defined. This one is tegra specific > > > driver so should be fine. But I am still bit nervous to export > > > cpu_logical_map as we have no clue what that would mean for physical > > > hotplug. > > > > As suggested, I have done below change to get the cluster number using > > read_cpuid_mpidr(). Please review and suggest if this looks ok? > > I will send formal patch if the change is fine. > > > > diff --git a/drivers/cpufreq/tegra194-cpufreq.c > > b/drivers/cpufreq/tegra194-cpufreq.c > > index bae527e..06f5ccf 100644 > > --- a/drivers/cpufreq/tegra194-cpufreq.c > > +++ b/drivers/cpufreq/tegra194-cpufreq.c > > @@ -56,9 +56,11 @@ struct read_counters_work { > > > > static struct workqueue_struct *read_counters_wq; > > > > -static enum cluster get_cpu_cluster(u8 cpu) > > +static void get_cpu_cluster(void *cluster) > > { > > - return MPIDR_AFFINITY_LEVEL(cpu_logical_map(cpu), 1); > > + u64 mpidr = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > > + > > + *((uint32_t *) cluster) = MPIDR_AFFINITY_LEVEL(mpidr, 1); > > } > > > > /* > > @@ -186,8 +188,10 @@ static unsigned int tegra194_get_speed(u32 cpu) > > static int tegra194_cpufreq_init(struct cpufreq_policy *policy) > > { > > struct tegra194_cpufreq_data *data = cpufreq_get_driver_data(); > > - int cl = get_cpu_cluster(policy->cpu); > > u32 cpu; > > + u32 cl; > > + > > + smp_call_function_single(policy->cpu, get_cpu_cluster, &cl, true); > > Thanks for this, looks good to me. You can add: > > Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> I already merged Kefeng's __cpu_logical_map fix (commit eaecca9e7710) but if the above goes in, I can drop the EXPORT_SYMBOL part (and keep the rest as it's a good refactoring). -- Catalin ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] arm64: Export __cpu_logical_map 2020-08-10 10:19 ` Catalin Marinas @ 2020-08-10 12:11 ` Sudeep Holla 2020-08-11 19:44 ` Sumit Gupta 1 sibling, 0 replies; 5+ messages in thread From: Sudeep Holla @ 2020-08-10 12:11 UTC (permalink / raw) To: Catalin Marinas Cc: Sumit Gupta, Kefeng Wang, Will Deacon, Mikko Perttunen, Viresh Kumar, Hulk Robot, linux-kernel@vger.kernel.org List, linux-arm-kernel, Bibek Basu, linux-tegra, Thierry Reding, Jon Hunter On Mon, Aug 10, 2020 at 11:19:55AM +0100, Catalin Marinas wrote: > On Mon, Aug 10, 2020 at 08:49:56AM +0100, Sudeep Holla wrote: > > On Sat, Aug 01, 2020 at 05:46:43PM +0530, Sumit Gupta wrote: > > > > > > > > ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! > > > > > > > > > > > > > > > > ARM64 tegra194-cpufreq driver use cpu_logical_map, export > > > > > > > > __cpu_logical_map to fix build issue. > > > > > > > > > > > > > > > > > > > > I wonder why like other instances in the drivers, the mpidr is not get > > > > > > directly from the cpu. The cpufreq_driver->init call happens when the cpu > > > > > > is being brought online and is executed on the required cpu IIUC. > > > > > > > > > > Yes, this occurs during hotplug case. > > > > > But in the case of system boot, 'cpufreq_driver->init' is called later > > > > > during cpufreq platform driver's probe. The value of CPU in 'policy->cpu' > > > > > can be different from the current CPU. That's why read_cpuid_mpidr() can't > > > > > be used. > > > > > > > > Fair enough, why not do cross call like in set_target ? Since it is one-off > > > > in init, I don't see any issue when you are doing it runtime for set_target. > > > > > > > > > > read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map. > > > > > > Though we may not add physical hotplug anytime soon, less dependency > > > > > > on this cpu_logical_map is better given that we can resolve this without > > > > > > the need to access the map. > > > > > > > > To be honest, we have tried to remove all the dependency on cluster id > > > > in generic code as it is not well defined. This one is tegra specific > > > > driver so should be fine. But I am still bit nervous to export > > > > cpu_logical_map as we have no clue what that would mean for physical > > > > hotplug. > > > > > > As suggested, I have done below change to get the cluster number using > > > read_cpuid_mpidr(). Please review and suggest if this looks ok? > > > I will send formal patch if the change is fine. > > > > > > diff --git a/drivers/cpufreq/tegra194-cpufreq.c > > > b/drivers/cpufreq/tegra194-cpufreq.c > > > index bae527e..06f5ccf 100644 > > > --- a/drivers/cpufreq/tegra194-cpufreq.c > > > +++ b/drivers/cpufreq/tegra194-cpufreq.c > > > @@ -56,9 +56,11 @@ struct read_counters_work { > > > > > > static struct workqueue_struct *read_counters_wq; > > > > > > -static enum cluster get_cpu_cluster(u8 cpu) > > > +static void get_cpu_cluster(void *cluster) > > > { > > > - return MPIDR_AFFINITY_LEVEL(cpu_logical_map(cpu), 1); > > > + u64 mpidr = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; > > > + > > > + *((uint32_t *) cluster) = MPIDR_AFFINITY_LEVEL(mpidr, 1); > > > } > > > > > > /* > > > @@ -186,8 +188,10 @@ static unsigned int tegra194_get_speed(u32 cpu) > > > static int tegra194_cpufreq_init(struct cpufreq_policy *policy) > > > { > > > struct tegra194_cpufreq_data *data = cpufreq_get_driver_data(); > > > - int cl = get_cpu_cluster(policy->cpu); > > > u32 cpu; > > > + u32 cl; > > > + > > > + smp_call_function_single(policy->cpu, get_cpu_cluster, &cl, true); > > > > Thanks for this, looks good to me. You can add: > > > > Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> > > I already merged Kefeng's __cpu_logical_map fix (commit eaecca9e7710) > but if the above goes in, I can drop the EXPORT_SYMBOL part (and keep > the rest as it's a good refactoring). > OK, I will keep an eye on this and we can drop export once this is merged. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] arm64: Export __cpu_logical_map 2020-08-10 10:19 ` Catalin Marinas 2020-08-10 12:11 ` Sudeep Holla @ 2020-08-11 19:44 ` Sumit Gupta 1 sibling, 0 replies; 5+ messages in thread From: Sumit Gupta @ 2020-08-11 19:44 UTC (permalink / raw) To: Catalin Marinas, Sudeep Holla Cc: Kefeng Wang, Will Deacon, Mikko Perttunen, Viresh Kumar, Hulk Robot, linux-kernel@vger.kernel.org List, linux-arm-kernel, Bibek Basu, linux-tegra, Thierry Reding, Jon Hunter >>>>>>>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! >>>>>>>> >>>>>>>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export >>>>>>>> __cpu_logical_map to fix build issue. >>>>>>>> >>>>>> >>>>>> I wonder why like other instances in the drivers, the mpidr is not get >>>>>> directly from the cpu. The cpufreq_driver->init call happens when the cpu >>>>>> is being brought online and is executed on the required cpu IIUC. >>>>> >>>>> Yes, this occurs during hotplug case. >>>>> But in the case of system boot, 'cpufreq_driver->init' is called later >>>>> during cpufreq platform driver's probe. The value of CPU in 'policy->cpu' >>>>> can be different from the current CPU. That's why read_cpuid_mpidr() can't >>>>> be used. >>>> >>>> Fair enough, why not do cross call like in set_target ? Since it is one-off >>>> in init, I don't see any issue when you are doing it runtime for set_target. >>>> >>>>>> read_cpuid_mpidr() is inline and avoids having to export the logical_cpu_map. >>>>>> Though we may not add physical hotplug anytime soon, less dependency >>>>>> on this cpu_logical_map is better given that we can resolve this without >>>>>> the need to access the map. >>>> >>>> To be honest, we have tried to remove all the dependency on cluster id >>>> in generic code as it is not well defined. This one is tegra specific >>>> driver so should be fine. But I am still bit nervous to export >>>> cpu_logical_map as we have no clue what that would mean for physical >>>> hotplug. >>> >>> As suggested, I have done below change to get the cluster number using >>> read_cpuid_mpidr(). Please review and suggest if this looks ok? >>> I will send formal patch if the change is fine. >>> >>> diff --git a/drivers/cpufreq/tegra194-cpufreq.c >>> b/drivers/cpufreq/tegra194-cpufreq.c >>> index bae527e..06f5ccf 100644 >>> --- a/drivers/cpufreq/tegra194-cpufreq.c >>> +++ b/drivers/cpufreq/tegra194-cpufreq.c >>> @@ -56,9 +56,11 @@ struct read_counters_work { >>> >>> static struct workqueue_struct *read_counters_wq; >>> >>> -static enum cluster get_cpu_cluster(u8 cpu) >>> +static void get_cpu_cluster(void *cluster) >>> { >>> - return MPIDR_AFFINITY_LEVEL(cpu_logical_map(cpu), 1); >>> + u64 mpidr = read_cpuid_mpidr() & MPIDR_HWID_BITMASK; >>> + >>> + *((uint32_t *) cluster) = MPIDR_AFFINITY_LEVEL(mpidr, 1); >>> } >>> >>> /* >>> @@ -186,8 +188,10 @@ static unsigned int tegra194_get_speed(u32 cpu) >>> static int tegra194_cpufreq_init(struct cpufreq_policy *policy) >>> { >>> struct tegra194_cpufreq_data *data = cpufreq_get_driver_data(); >>> - int cl = get_cpu_cluster(policy->cpu); >>> u32 cpu; >>> + u32 cl; >>> + >>> + smp_call_function_single(policy->cpu, get_cpu_cluster, &cl, true); >> >> Thanks for this, looks good to me. You can add: >> >> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> > > I already merged Kefeng's __cpu_logical_map fix (commit eaecca9e7710) > but if the above goes in, I can drop the EXPORT_SYMBOL part (and keep > the rest as it's a good refactoring). > I have posted the formal patch. Thanks, Sumit > -- > Catalin > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-11 19:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200724030433.22287-1-wangkefeng.wang@huawei.com>
[not found] ` <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com>
[not found] ` <20200724131059.GB6521@bogus>
[not found] ` <00cf6e67-16ed-872d-2c16-0ceea6b6f514@nvidia.com>
[not found] ` <20200727160515.GA8003@bogus>
2020-08-01 12:16 ` [PATCH -next] arm64: Export __cpu_logical_map Sumit Gupta
2020-08-10 7:49 ` Sudeep Holla
2020-08-10 10:19 ` Catalin Marinas
2020-08-10 12:11 ` Sudeep Holla
2020-08-11 19:44 ` Sumit Gupta
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).