From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C944C2B9F4 for ; Tue, 22 Jun 2021 14:12:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 265EC61042 for ; Tue, 22 Jun 2021 14:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231478AbhFVOOw (ORCPT ); Tue, 22 Jun 2021 10:14:52 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:37390 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230526AbhFVOOw (ORCPT ); Tue, 22 Jun 2021 10:14:52 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 75F6721986; Tue, 22 Jun 2021 14:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624371155; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qt9ifZERVwphuvdnSSK7DiTxmCTtBvIrdP9GVnQs/Ys=; b=IgLurosHDvQpAn1MzKrof3G5IQ+plyP5/OhgUd8L8c6qGYS5tVNrwfOxB1qAhkjwKyDl80 bxCrPyiO/Plx7h+jnTxjNn+Eol2d5mSvRoordggUiuDFPVR14nX1Uh1YhAAN3zvZSpeN8Y URSUOSTE01ufpVOmN4WBCh1g99ZYQZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624371155; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qt9ifZERVwphuvdnSSK7DiTxmCTtBvIrdP9GVnQs/Ys=; b=rdjf4bYFCEC6GVfu1QNSzYyZOzjQG2BqSeukRhBV8hUkIn6Uw9a1IPHzRCVIUalS940Le8 zujah5+IBtk5uVCQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 607D3A3B95; Tue, 22 Jun 2021 14:12:34 +0000 (UTC) Date: Tue, 22 Jun 2021 16:12:34 +0200 Message-ID: From: Takashi Iwai To: Jiajun Cao Cc: yuanxzhang@fudan.edu.cn, Xin Tan , Jaroslav Kysela , Takashi Iwai , Thierry Reding , Jonathan Hunter , Dmitry Osipenko , Mohan Kumar , Peter Geis , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci: hda: Add IRQ check for platform_get_irq() In-Reply-To: <20210622131947.94346-1-jjcao20@fudan.edu.cn> References: <20210622131947.94346-1-jjcao20@fudan.edu.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, 22 Jun 2021 15:19:42 +0200, Jiajun Cao wrote: > > The function hda_tegra_first_init() neglects to check the return > value after executing platform_get_irq(). > > hda_tegra_first_init() should check the return value (if negative > error number) for errors so as to not pass a negative value to > the devm_request_irq(). > > Fix it by adding a check for the return value irq_id. > > Signed-off-by: Jiajun Cao > Signed-off-by: Xin Tan Applied, thanks. Takashi