From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10339C433FE for ; Wed, 8 Sep 2021 07:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2CF3610A3 for ; Wed, 8 Sep 2021 07:33:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348217AbhIHHer (ORCPT ); Wed, 8 Sep 2021 03:34:47 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:35290 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347750AbhIHHeq (ORCPT ); Wed, 8 Sep 2021 03:34:46 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 693A12223D; Wed, 8 Sep 2021 07:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1631086418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6h8YZTx7xXQnfNkm+DDzIlZYm7doAL7yUOPCHmJhXno=; b=gl7tPg2mIal5OlfCS+rQJuMgcY7RpyMW3EVn0n/klpIeYZ9azHkJb5hdj6HcAgawfm5H2g us+M4DYK6/V0WDPC0tjTcdA4chP6fQI3z+FiNuDDzmfsr2t+ndy5kmcwFBVsKS3cTCKRXp 5lh+4y1bnkFh7saqWLJGZNTdg/fz5XY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1631086418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6h8YZTx7xXQnfNkm+DDzIlZYm7doAL7yUOPCHmJhXno=; b=d19bmkWJi/WUfz4U0sz4wkaD+dAZ3diBGJgcUfm64+uvZug6E4WvGsl/k2HIec8zs2eRQV rsSZxM/ujD1tllBg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id ECB1313721; Wed, 8 Sep 2021 07:33:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id EGAAOFFnOGE9RQAAGKfGzw (envelope-from ); Wed, 08 Sep 2021 07:33:37 +0000 Message-ID: <124a19ef-0b50-2cf2-c6cc-12f443706883@suse.cz> Date: Wed, 8 Sep 2021 09:33:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH 02/24] x86/traps: Move arch/x86/kernel/traps.c to arch/x86/entry/ Content-Language: en-US To: Nick Desaulniers Cc: Peter Zijlstra , Miguel Ojeda , Lai Jiangshan , Joerg Roedel , Lai Jiangshan , linux-kernel@vger.kernel.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Daniel Bristot de Oliveira , Brijesh Singh , Andy Shevchenko , Arvind Sankar , Chester Lin , Juergen Gross , andrew.cooper3@citrix.com, linux-toolchains@vger.kernel.org References: <20210831175025.27570-1-jiangshanlai@gmail.com> <20210831175025.27570-3-jiangshanlai@gmail.com> <1f327579-e62a-df65-0763-e88243829db3@linux.alibaba.com> <4c589fef-8c98-a6fc-693f-b205a7710e42@linux.alibaba.com> <36cf9869-4e4d-e0c6-bf71-981285bd8041@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On 9/7/21 23:12, Nick Desaulniers wrote: > On Fri, Sep 3, 2021 at 12:36 AM Martin Liška wrote: >> >> On 9/2/21 19:05, Nick Desaulniers wrote: >>> IIRC GCC only >>> added the attribute recently in the 10.X release, so it might be too >>> new to rely on quite yet. >> >> The no_stack_protector attribute was actually added in the GCC 11.x release: >> https://gcc.gnu.org/gcc-11/changes.html > > Ah right, that lays more weight though that this feature is still too > new to rely on quite yet. Sure. > Martin, do you know if what happens with > regards to inlining when the callee and caller mismatch on this > function attribute in GCC? This is very much a problem for the > kernel. That's a know issue that was already discusses both in a Kernel mailing and GCC bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94722#c9 Martin > >> Note the compiler is definitely used by Fedora, openSUSE Tumbleweed >> and other cutting edge distributions. > > Kernel supports GCC 4.9+ currently. This feature can only be emulated > with the coarse grain -fno-stack-protector (or gnu_inline with out of > line assembler definition...:( ). >