From: Nathan Chancellor <natechancellor@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Jakub Jelinek <jakub@redhat.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-toolchains@vger.kernel.org,
clang-built-linux <clang-built-linux@googlegroups.com>,
Fangrui Song <maskray@google.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Dmitry Golovin <dima@golovin.in>,
Alistair Delva <adelva@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/4] Kbuild: do not emit debug info for assembly with LLVM_IAS=1
Date: Wed, 4 Nov 2020 23:58:44 -0700 [thread overview]
Message-ID: <20201105065844.GA3243074@ubuntu-m3-large-x86> (raw)
In-Reply-To: <20201104005343.4192504-3-ndesaulniers@google.com>
On Tue, Nov 03, 2020 at 04:53:41PM -0800, Nick Desaulniers wrote:
> Clang's integrated assembler produces the warning for assembly files:
>
> warning: DWARF2 only supports one section per compilation unit
>
> If -Wa,-gdwarf-* is unspecified, then debug info is not emitted. This
Is this something that should be called out somewhere? If I understand
this correctly, LLVM_IAS=1 + CONFIG_DEBUG_INFO=y won't work? Maybe this
should be handled in Kconfig?
> will be re-enabled for new DWARF versions in a follow up patch.
>
> Enables defconfig+CONFIG_DEBUG_INFO to build cleanly with
> LLVM=1 LLVM_IAS=1 for x86_64 and arm64.
>
> Cc: <stable@vger.kernel.org>
> Link: https://github.com/ClangBuiltLinux/linux/issues/716
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Suggested-by: Dmitry Golovin <dima@golovin.in>
If you happen to respin, Dmitry deserves a Reported-by tag too :)
> Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Regardless of the other two comments, this is fine as is as a fix for
stable to unblock Android + CrOS since we have been running something
similar to it in CI:
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index f353886dbf44..75b1a3dcbf30 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -826,7 +826,9 @@ else
> DEBUG_CFLAGS += -g
> endif
>
> +ifndef LLVM_IAS
Nit: this should probably match the existing LLVM_IAS check
ifneq ($(LLVM_IAS),1)
> KBUILD_AFLAGS += -Wa,-gdwarf-2
> +endif
>
> ifdef CONFIG_DEBUG_INFO_DWARF4
> DEBUG_CFLAGS += -gdwarf-4
> --
> 2.29.1.341.ge80a0c044ae-goog
>
next prev parent reply other threads:[~2020-11-05 6:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 1:21 [PATCH] Kbuild: implement support for DWARF5 Nick Desaulniers
2020-10-22 1:44 ` Fangrui Song
2020-11-03 22:27 ` Nick Desaulniers
2020-10-28 18:18 ` Nick Desaulniers
2020-11-02 2:20 ` Masahiro Yamada
2020-11-02 8:18 ` Jakub Jelinek
2020-11-03 22:21 ` Nick Desaulniers
2020-11-04 12:19 ` Jakub Jelinek
2020-11-03 22:13 ` Nick Desaulniers
2020-11-04 0:53 ` [PATCH v2 0/4] Kbuild: DWARF v5 support Nick Desaulniers
2020-11-04 0:53 ` [PATCH v2 1/4] x86_64: Change .weak to SYM_FUNC_START_WEAK for arch/x86/lib/mem*_64.S Nick Desaulniers
2020-11-04 0:53 ` [PATCH v2 2/4] Kbuild: do not emit debug info for assembly with LLVM_IAS=1 Nick Desaulniers
2020-11-05 6:58 ` Nathan Chancellor [this message]
2020-11-05 7:26 ` Fangrui Song
2020-11-09 18:28 ` Nick Desaulniers
2020-11-09 18:35 ` [PATCH v3] " Nick Desaulniers
2020-11-16 23:41 ` Nick Desaulniers
[not found] ` <CA+SOCLJTg6U+Ddop_5O-baVR42va3vGAvMQ62o9H6rd+10aKrw@mail.gmail.com>
2020-11-23 18:42 ` Nick Desaulniers
2020-11-24 18:44 ` Masahiro Yamada
2020-11-04 0:53 ` [PATCH v2 3/4] Kbuild: make DWARF version a choice Nick Desaulniers
2020-11-05 5:58 ` kernel test robot
2020-11-23 23:22 ` Arvind Sankar
2020-11-24 0:33 ` Segher Boessenkool
2020-11-24 16:56 ` Arvind Sankar
2020-11-24 17:46 ` Segher Boessenkool
2020-11-30 18:04 ` Masahiro Yamada
2020-11-30 20:27 ` Fāng-ruì Sòng
2020-12-01 3:38 ` Masahiro Yamada
2020-12-01 9:32 ` Segher Boessenkool
2020-12-02 1:08 ` Fāng-ruì Sòng
2020-11-30 20:45 ` Nick Desaulniers
2020-12-01 4:17 ` Masahiro Yamada
2020-11-04 0:53 ` [PATCH v2 4/4] Kbuild: implement support for DWARF v5 Nick Desaulniers
2020-11-24 17:28 ` Arvind Sankar
2020-12-03 23:22 ` Nick Desaulniers
2020-12-03 23:28 ` Nick Desaulniers
2020-12-04 17:06 ` Arvind Sankar
2020-12-10 23:18 ` Nick Desaulniers
2020-12-11 0:29 ` Arvind Sankar
2020-12-01 1:56 ` Masahiro Yamada
2020-11-04 0:00 ` [PATCH] Kbuild: implement support for DWARF5 Arvind Sankar
2020-11-04 0:05 ` Nick Desaulniers
2020-11-04 0:17 ` Arvind Sankar
2020-12-03 22:56 ` Nick Desaulniers
2020-12-04 0:17 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105065844.GA3243074@ubuntu-m3-large-x86 \
--to=natechancellor@gmail.com \
--cc=adelva@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dima@golovin.in \
--cc=jakub@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).