linux-toolchains.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Bill Wendling <wcw@google.com>,
	Sami Tolvanen <samitolvanen@google.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Ard Biesheuvel <ardb@kernel.org>, Will Deacon <will@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
	x86@kernel.org, Borislav Petkov <bp@alien8.de>,
	Martin Liska <mliska@suse.cz>, Marco Elver <elver@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Fangrui Song <maskray@google.com>,
	linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Dmitry Vyukov <dvyukov@google.com>,
	johannes.berg@intel.com, linux-toolchains@vger.kernel.org
Subject: Re: [PATCH 0/2] no_profile fn attr and Kconfig for GCOV+PGO
Date: Fri, 18 Jun 2021 19:45:45 -0700	[thread overview]
Message-ID: <202106181945.AC10BF38ED@keescook> (raw)
In-Reply-To: <20210618233023.1360185-1-ndesaulniers@google.com>

On Fri, Jun 18, 2021 at 04:30:21PM -0700, Nick Desaulniers wrote:
> When we say noinstr, we mean noinstr.  GCOV and PGO can both instrument
> functions. Add a new function annotation __no_profile that expands to
> __attribute__((__no_profile__)) and Kconfig value
> CC_HAS_NO_PROFILE_FN_ATTR.
> 
> Base is
> https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/clang/pgo.
> 
> Nick Desaulniers (2):
>   compiler_attributes.h: define __no_profile, add to noinstr
>   Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO

Oh, awesome! Thanks for the fast work on this. If there are no objections,
I'll apply this in front of the PGO series and put it in -next.

-Kees

> 
>  include/linux/compiler_attributes.h | 12 ++++++++++++
>  include/linux/compiler_types.h      |  2 +-
>  init/Kconfig                        |  3 +++
>  kernel/gcov/Kconfig                 |  1 +
>  kernel/pgo/Kconfig                  |  3 ++-
>  5 files changed, 19 insertions(+), 2 deletions(-)
> 
> 
> base-commit: 4356bc4c0425c81e204f561acf4dd0095544a6cb
> -- 
> 2.32.0.288.g62a8d224e6-goog
> 

-- 
Kees Cook

  parent reply	other threads:[~2021-06-19  2:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 23:30 [PATCH 0/2] no_profile fn attr and Kconfig for GCOV+PGO Nick Desaulniers
2021-06-18 23:30 ` [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr Nick Desaulniers
2021-06-19 11:26   ` Miguel Ojeda
2021-06-19 11:32     ` Miguel Ojeda
2021-06-21 18:10       ` Nick Desaulniers
2021-06-21 18:24         ` Fangrui Song
2021-06-21 19:09           ` Miguel Ojeda
2021-06-18 23:30 ` [PATCH 2/2] Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Nick Desaulniers
2021-06-19  6:23   ` Marco Elver
2021-06-21 18:22     ` Nick Desaulniers
2021-06-21 18:50       ` Bill Wendling
2021-06-21 20:43         ` Nick Desaulniers
2021-06-21 21:15           ` Nathan Chancellor
2021-06-22  9:25           ` Catalin Marinas
2021-06-22  9:29             ` Mark Rutland
2021-06-22  9:32               ` Catalin Marinas
2021-06-18 23:52 ` [PATCH 0/2] no_profile fn attr and Kconfig for GCOV+PGO Fangrui Song
2021-06-19  2:45 ` Kees Cook [this message]
2021-06-20  8:08   ` Bill Wendling
2021-06-20 14:53   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106181945.AC10BF38ED@keescook \
    --to=keescook@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=corbet@lwn.net \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-toolchains@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=masahiroy@kernel.org \
    --cc=maskray@google.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mliska@suse.cz \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=oberpar@linux.ibm.com \
    --cc=peterz@infradead.org \
    --cc=samitolvanen@google.com \
    --cc=wcw@google.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).