From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51782C48BC2 for ; Mon, 21 Jun 2021 18:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 280BA6054E for ; Mon, 21 Jun 2021 18:24:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbhFUS0k (ORCPT ); Mon, 21 Jun 2021 14:26:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231241AbhFUS0k (ORCPT ); Mon, 21 Jun 2021 14:26:40 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5EEDC061756 for ; Mon, 21 Jun 2021 11:24:25 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id a127so3776039pfa.10 for ; Mon, 21 Jun 2021 11:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8srstiN/1QZXwDTulF83V5rnWY0uXObxwuHnse4sC/A=; b=mbdRjmeqpU09zwARWs6VBWCsKthtt1ciZ7/sKECb+LXhO/trEQk1wiQ8V1CZ0EV2Jm ZlEkgW0zlljp2e/FgFuPRW9rdjI05xum01p50e9bFYSmMCNHbE5kQqAAo8oW420leycF l0vqb2QcSakmgDG0XDSPywc8AdQoRSaV2MRpsf1z/7e/SYs0HhYtYQWrwQE/QE4PjipG c4TpQZj3g/Yj1i5YmfIbNfvRTE4EkwYphVE25FDEvIvwz2vNVjsu4RuTd9AcI1aE94qc 6y/mckyWvHWNGxtF6OvgOWOlNbuvcJGnmCcaDgeccujmVJiAIXsJrfar32C9U2x7wAJX 6Gqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8srstiN/1QZXwDTulF83V5rnWY0uXObxwuHnse4sC/A=; b=Hbls9rKf2zPAE2C5u9bATqkP1uthlGrzzPaw/78HcmPrzEukgGTMCqaysLOokEW7Wo OTi86j0wZHyuVGxqCQxFY5i7+vct3Q+HvBk9GN2LPyTvKjZoocTbP6UpncwYnz8dUcm8 hFt4vzcZq481L4vfiQ7WGeb0SI9m6E2i3lWljHis3W8eaR4lN4oGYpff4qM1jnSBLYcI a1u57l+J1VxJIXca/0y9QeA/Ab9CSPQnP3E7qopJGZ012CPkgxFqhMePEKCaXuOGQuyW 8aZJuEv5DjjKuQYGEIyF5kJhMtP9Gp2w2/KriYgzLOQzseD8B9CNje3dFKfwfQE/7PYj iKGA== X-Gm-Message-State: AOAM5316hfpQDU2VxL0tD0iC+2q40q8E7AqLGzHG+Pjs1jxkIw63MLG3 h3uoEpZs40AVl3HI1rNc8myU1g== X-Google-Smtp-Source: ABdhPJwsKW/VhOsBp1lMcO0miiGnEaYNCbevivBl7JAn5W5XepPB84CTUFkwR3IV2ygsBGL4tRrmSA== X-Received: by 2002:a63:1143:: with SMTP id 3mr25502463pgr.166.1624299865199; Mon, 21 Jun 2021 11:24:25 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:33e1:52f0:4159:6ed]) by smtp.gmail.com with ESMTPSA id b18sm4756953pft.1.2021.06.21.11.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 11:24:24 -0700 (PDT) Date: Mon, 21 Jun 2021 11:24:18 -0700 From: Fangrui Song To: Nick Desaulniers Cc: Miguel Ojeda , Kees Cook , Peter Zijlstra , Bill Wendling , Sami Tolvanen , Peter Oberparleiter , Masahiro Yamada , Nathan Chancellor , Luc Van Oostenryck , Ard Biesheuvel , Will Deacon , Arnd Bergmann , Andrew Morton , Rasmus Villemoes , linux-kernel , clang-built-linux , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Borislav Petkov , Martin Liska , Marco Elver , Jonathan Corbet , Linux Doc Mailing List , Linux Kbuild mailing list , Dmitry Vyukov , Johannes Berg , linux-toolchains@vger.kernel.org Subject: Re: [PATCH 1/2] compiler_attributes.h: define __no_profile, add to noinstr Message-ID: <20210621182418.57qbumtovysrlkwy@google.com> References: <20210618233023.1360185-1-ndesaulniers@google.com> <20210618233023.1360185-2-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On 2021-06-21, Nick Desaulniers wrote: >On Sat, Jun 19, 2021 at 4:32 AM Miguel Ojeda > wrote: >> >> On Sat, Jun 19, 2021 at 1:26 PM Miguel Ojeda >> wrote: >> > >> > I am not sure if it is best or not to have the GCC link in order to be >> > consistent with the rest of the links (they are for the docs only). Do >> > we know if GCC going to implement it soon? >> >> i.e. if GCC does not implement it yet we use elsewhere this kind of >> marker instead: >> >> * Optional: not supported by gcc >> >> The first of its kind, normally it is clang/icc there ;-) > >:^) GCC does have an attribute since GCC 7.1 for this. >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80223#c11 >I'm moving Clang over to use that in >https://reviews.llvm.org/D104658 >Once that lands, I'll send a v2 (without carrying any reviewed by tags). Thanks! __attribute__((no_profile_instrument_function)) looks good to me. Also a reminder that __GCC4_has_attribute___no_profile in v1 misses two underscores. v2 no_profile_instrument_function may need to fix this. Reviewed-by: Fangrui Song >> >> We could nevertheless have the link there, something like: >> >> * Optional: not supported by GCC >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80223 > >-- >Thanks, >~Nick Desaulniers