From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 062E6C433F5 for ; Sat, 11 Sep 2021 21:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8EF56113E for ; Sat, 11 Sep 2021 21:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbhIKVi0 (ORCPT ); Sat, 11 Sep 2021 17:38:26 -0400 Received: from gate.crashing.org ([63.228.1.57]:56841 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231472AbhIKViZ (ORCPT ); Sat, 11 Sep 2021 17:38:25 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 18BLY2Jn030379; Sat, 11 Sep 2021 16:34:02 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 18BLY1Q0030378; Sat, 11 Sep 2021 16:34:01 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Sat, 11 Sep 2021 16:34:01 -0500 From: Segher Boessenkool To: Peter Zijlstra Cc: masahiroy@kernel.org, linux-kernel@vger.kernel.org, nathan@kernel.org, ndesaulniers@google.com, x86@kernel.org, linux-toolchains@vger.kernel.org Subject: Re: [PATCH] Makefile: 'Promote' -Wunused-but-set-variable to W=3 Message-ID: <20210911213401.GE1583@gate.crashing.org> References: <20210911142905.GZ4323@worktop.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210911142905.GZ4323@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On Sat, Sep 11, 2021 at 04:29:05PM +0200, Peter Zijlstra wrote: > Upgrade -Wunused-but-set-variable to W=3 to avoid the build robots > sending endless spam for this garbage warning. "This warning for garbage code" you mean? > By promoting it to W=3 the robots will no longer report it and people > will no longer attempt to fix them by making the code worse. Instead, they will not see such warnings, and make the code worse. Segher