From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDB8C38A2D for ; Wed, 26 Oct 2022 00:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231645AbiJZAKJ (ORCPT ); Tue, 25 Oct 2022 20:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231844AbiJZAKH (ORCPT ); Tue, 25 Oct 2022 20:10:07 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B39C7A2866 for ; Tue, 25 Oct 2022 17:10:05 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id t15so4237375edd.4 for ; Tue, 25 Oct 2022 17:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4taiE5ssQYH2zlfw716I5D+61K8WmNsXSyJ4aqN82N8=; b=icD7feogwbnZHXxEHSUlJiUdinyKhya/zRuuqtoVUhyaraQ0seuTNAk/XrxuwJ0hxQ +RHi4wpnmQXkdR81PLGgT49IxOWoALW+IFaAfe8ECx3bjTYBHnBCZBluni8j1cgygBJG xgmIG0ZBIm2nZn5xaAhnqeRvJwkGoND+Q7SEo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4taiE5ssQYH2zlfw716I5D+61K8WmNsXSyJ4aqN82N8=; b=b4P02mNts1sQ4SyKXxRKeOz3/CVd40B69/0by3BEtWFcbE4hHpZwjyYXzag4uwx401 3mci+SohPtpuWgjaYoeOJcOaveLVxEVVWRU1kDvDN00gCwZOpo/2qcTcXUZ/1LaGBAxo VsG+MAk7EfTRmltmPJZTdJ7OwQ8/u1aiSg5XZ8YG77Hzb3+AxWSGam6U+agJL4tvd/P0 JK+Q926k04FEEQn4HcytCmlMuB5K5tIyTFYad09CMPIqbJdMUDGacT/KXnYdU4v+1dTj SUJTJLZYQ3a1qVX+x7D0YNzxRl/X78mWbwLkmDT2ZRHNzr8G5VsKC3ADdbhPKxBPCEW/ vsyQ== X-Gm-Message-State: ACrzQf33UhkYC4Bci8oJ5itLpHrsulAq/cVtSO+Ki9KP9QJKCSRedfjN PsFGJxdGQBbfI8+IEDNMuYRAig== X-Google-Smtp-Source: AMsMyM7YfH3zjdroxgQqniV4fSiNgFe9/PT7uYZeGKrCNU79xQR9xfgcxWPG1xDwPXa1oHQRbz8xag== X-Received: by 2002:a05:6402:5288:b0:457:22e5:8022 with SMTP id en8-20020a056402528800b0045722e58022mr37785972edb.244.1666743004203; Tue, 25 Oct 2022 17:10:04 -0700 (PDT) Received: from [192.168.1.149] ([80.208.71.65]) by smtp.gmail.com with ESMTPSA id a7-20020a17090640c700b0073d7bef38e3sm2104978ejk.45.2022.10.25.17.10.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 17:10:03 -0700 (PDT) Message-ID: <3a2fa7c1-2e31-0479-761f-9c189f8ed8c3@rasmusvillemoes.dk> Date: Wed, 26 Oct 2022 02:10:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: make ctype ascii only? (was [PATCH] kbuild: treat char as always signed) Content-Language: en-US To: Linus Torvalds , "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, linux-toolchains@vger.kernel.org, Masahiro Yamada , Kees Cook , Andrew Morton , Andy Shevchenko , Greg Kroah-Hartman References: <20221019162648.3557490-1-Jason@zx2c4.com> From: Rasmus Villemoes In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On 19/10/2022 21.54, Linus Torvalds wrote: > On Wed, Oct 19, 2022 at 9:27 AM Jason A. Donenfeld wrote: >> >> So let's just eliminate this particular variety of heisensigned bugs >> entirely. Set `-fsigned-char` globally, so that gcc makes the type >> signed on all architectures. > > Btw, I do wonder if we might actually be better off doing this - but > doing it the other way around. Only very tangentially related (because it has to do with chars...): Can we switch our ctype to be ASCII only, just as it was back in the good'ol mid 90s [i.e. before https://git.kernel.org/pub/scm/linux/kernel/git/mpe/linux-fullhistory.git/commit/lib/ctype.c?id=036b97b05489161be06e63be77c5fad9247d23ff]. It bugs me that it's almost-but-not-quite-latin1, that toupper() isn't idempotent, and that one can hit an isalpha() with toupper() and get something that isn't isalpha(). Rasmus