From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B979C678D5 for ; Tue, 7 Mar 2023 21:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231290AbjCGVMR (ORCPT ); Tue, 7 Mar 2023 16:12:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbjCGVML (ORCPT ); Tue, 7 Mar 2023 16:12:11 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43110A8C65 for ; Tue, 7 Mar 2023 13:12:02 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id i34so57798424eda.7 for ; Tue, 07 Mar 2023 13:12:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1678223520; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d3EmGp5fzDwlHCmDu7H4pzhEBDJeCZ+kE8lTuXvrdGw=; b=ARgSpTGAtBt1MSB572428Gc9IoEyDcC29YKIKorFhM7TUwzgli/V85ZMdzoRIYRuLZ YjsgNWF4Yaf0YijGkeXUxRSKGplgAfOTkUT3A0UQJ+iA4yrn4p941uT36aG1herjjkWa YCoFJNgDE/Speqyjrsc6K9t4A0RWSuv1azHYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678223520; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d3EmGp5fzDwlHCmDu7H4pzhEBDJeCZ+kE8lTuXvrdGw=; b=nkTd8QXXp1Atbob8BedpRU0rODczNphuGw6Qoz3VDIqVpvRtMLrde2GcJaLxCngQBR fZ/aNpvQZ782fu0bpsA33ViSL2TNanta6ttm6XVryx70EH78GL27ASyzvGylPI9QFepw UL4LViS363ZCQxlePkFSIYCNFRTAuguaxbdUAGvDTQTDXtdiJcdE5yfL94syhMoldDer OpLI575N7NQ+jlA7xOfWSGApJyA62OOXKwRH5jvSeMljWamnWNz1VeDhOn7lYi68eCrg +RUc/jeHvze20r1O3k0KXF7SK0gM59qE1IJ064q2kQrdqoAxzFT9OP4LYbBwPEdV2Ksc HbrA== X-Gm-Message-State: AO0yUKWK/1i8OYKUMNCxKp4mZmGcMFyGxa0D/Jr8fPk+89z4K3yacInD Demjhqw0HNeyVYda4p+qcZ51aMY1VTZNOxDxnOnXmF2P X-Google-Smtp-Source: AK7set+wJflH9+1U5OA67URG/+6tmri7hoz7SZy92ceWFwNGGeZ+hzaaLjiAhh4d87Xasv5oTDK+Eg== X-Received: by 2002:a17:906:4fd5:b0:8b1:78b8:4208 with SMTP id i21-20020a1709064fd500b008b178b84208mr18888751ejw.1.1678223520364; Tue, 07 Mar 2023 13:12:00 -0800 (PST) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id lf28-20020a170907175c00b008e0bb004976sm6600140ejc.134.2023.03.07.13.12.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Mar 2023 13:12:00 -0800 (PST) Received: by mail-ed1-f49.google.com with SMTP id g3so57922235eda.1 for ; Tue, 07 Mar 2023 13:12:00 -0800 (PST) X-Received: by 2002:a17:906:398a:b0:877:747e:f076 with SMTP id h10-20020a170906398a00b00877747ef076mr7345032eje.0.1678223206531; Tue, 07 Mar 2023 13:06:46 -0800 (PST) MIME-Version: 1.0 References: <20230303231133.1486085-1-eranian@google.com> <20230306120106.GE1267364@hirez.programming.kicks-ass.net> <20230307113545.GB2017917@hirez.programming.kicks-ass.net> <20230307184315.GS25951@gate.crashing.org> In-Reply-To: From: Linus Torvalds Date: Tue, 7 Mar 2023 13:06:29 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in To: Jakub Jelinek Cc: Segher Boessenkool , Peter Zijlstra , Nick Desaulniers , Stephane Eranian , linux-kernel@vger.kernel.org, tony.luck@intel.com, reinette.chatre@intel.com, fenghua.yu@intel.com, peternewman@google.com, james.morse@arm.com, babu.moger@amd.com, ananth.narayan@amd.com, vschneid@redhat.com, Nathan Chancellor , clang-built-linux , Borislav Petkov , "H. Peter Anvin" , linux-toolchains@vger.kernel.org Content-Type: multipart/mixed; boundary="000000000000148e7005f655ca63" Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org --000000000000148e7005f655ca63 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 7, 2023 at 12:54=E2=80=AFPM Linus Torvalds wrote: > > I think the problem is that the code is disgusting and > horrible in multiple ways: > > (a) it shouldn't define and declare a static function in a header file > > (b) the resctrl_sched_in() inline function is misdesigned to begin with Ok, so here's a *ttoally* untested and mindless patch to maybe fix what I dislike about that resctl code. Does it fix the code generation issue? I have no idea. But this is what I would suggest is the right answer, without actually knowing the code any better, and just going on a mindless rampage. It seems to compile for me, fwiw. Linus --000000000000148e7005f655ca63 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_leyqqvgo0 IGFyY2gveDg2L2luY2x1ZGUvYXNtL3Jlc2N0cmwuaCAgICAgICAgIHwgMTIgKysrKysrLS0tLS0t CiBhcmNoL3g4Ni9rZXJuZWwvY3B1L3Jlc2N0cmwvcmR0Z3JvdXAuYyB8ICA0ICsrLS0KIGFyY2gv eDg2L2tlcm5lbC9wcm9jZXNzXzMyLmMgICAgICAgICAgIHwgIDIgKy0KIGFyY2gveDg2L2tlcm5l bC9wcm9jZXNzXzY0LmMgICAgICAgICAgIHwgIDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC94ODYvaW5jbHVk ZS9hc20vcmVzY3RybC5oIGIvYXJjaC94ODYvaW5jbHVkZS9hc20vcmVzY3RybC5oCmluZGV4IDUy Nzg4Zjc5Nzg2Zi4uMjU1YTc4ZDlkOTA2IDEwMDY0NAotLS0gYS9hcmNoL3g4Ni9pbmNsdWRlL2Fz bS9yZXNjdHJsLmgKKysrIGIvYXJjaC94ODYvaW5jbHVkZS9hc20vcmVzY3RybC5oCkBAIC00OSw3 ICs0OSw3IEBAIERFQ0xBUkVfU1RBVElDX0tFWV9GQUxTRShyZHRfbW9uX2VuYWJsZV9rZXkpOwog ICogICBzaW1wbGUgYXMgcG9zc2libGUuCiAgKiBNdXN0IGJlIGNhbGxlZCB3aXRoIHByZWVtcHRp b24gZGlzYWJsZWQuCiAgKi8KLXN0YXRpYyB2b2lkIF9fcmVzY3RybF9zY2hlZF9pbih2b2lkKQor c3RhdGljIGlubGluZSB2b2lkIF9fcmVzY3RybF9zY2hlZF9pbihzdHJ1Y3QgdGFza19zdHJ1Y3Qg KnRzaykKIHsKIAlzdHJ1Y3QgcmVzY3RybF9wcXJfc3RhdGUgKnN0YXRlID0gdGhpc19jcHVfcHRy KCZwcXJfc3RhdGUpOwogCXUzMiBjbG9zaWQgPSBzdGF0ZS0+ZGVmYXVsdF9jbG9zaWQ7CkBAIC02 MSwxMyArNjEsMTMgQEAgc3RhdGljIHZvaWQgX19yZXNjdHJsX3NjaGVkX2luKHZvaWQpCiAJICog RWxzZSB1c2UgdGhlIGNsb3NpZC9ybWlkIGFzc2lnbmVkIHRvIHRoaXMgY3B1LgogCSAqLwogCWlm IChzdGF0aWNfYnJhbmNoX2xpa2VseSgmcmR0X2FsbG9jX2VuYWJsZV9rZXkpKSB7Ci0JCXRtcCA9 IFJFQURfT05DRShjdXJyZW50LT5jbG9zaWQpOworCQl0bXAgPSBSRUFEX09OQ0UodHNrLT5jbG9z aWQpOwogCQlpZiAodG1wKQogCQkJY2xvc2lkID0gdG1wOwogCX0KIAogCWlmIChzdGF0aWNfYnJh bmNoX2xpa2VseSgmcmR0X21vbl9lbmFibGVfa2V5KSkgewotCQl0bXAgPSBSRUFEX09OQ0UoY3Vy cmVudC0+cm1pZCk7CisJCXRtcCA9IFJFQURfT05DRSh0c2stPnJtaWQpOwogCQlpZiAodG1wKQog CQkJcm1pZCA9IHRtcDsKIAl9CkBAIC04OCwxNyArODgsMTcgQEAgc3RhdGljIGlubGluZSB1bnNp Z25lZCBpbnQgcmVzY3RybF9hcmNoX3JvdW5kX21vbl92YWwodW5zaWduZWQgaW50IHZhbCkKIAly ZXR1cm4gdmFsICogc2NhbGU7CiB9CiAKLXN0YXRpYyBpbmxpbmUgdm9pZCByZXNjdHJsX3NjaGVk X2luKHZvaWQpCitzdGF0aWMgaW5saW5lIHZvaWQgcmVzY3RybF9zY2hlZF9pbihzdHJ1Y3QgdGFz a19zdHJ1Y3QgKnRzaykKIHsKIAlpZiAoc3RhdGljX2JyYW5jaF9saWtlbHkoJnJkdF9lbmFibGVf a2V5KSkKLQkJX19yZXNjdHJsX3NjaGVkX2luKCk7CisJCV9fcmVzY3RybF9zY2hlZF9pbih0c2sp OwogfQogCiB2b2lkIHJlc2N0cmxfY3B1X2RldGVjdChzdHJ1Y3QgY3B1aW5mb194ODYgKmMpOwog CiAjZWxzZQogCi1zdGF0aWMgaW5saW5lIHZvaWQgcmVzY3RybF9zY2hlZF9pbih2b2lkKSB7fQor c3RhdGljIGlubGluZSB2b2lkIHJlc2N0cmxfc2NoZWRfaW4oc3RydWN0IHRhc2tfc3RydWN0ICp0 c2spIHt9CiBzdGF0aWMgaW5saW5lIHZvaWQgcmVzY3RybF9jcHVfZGV0ZWN0KHN0cnVjdCBjcHVp bmZvX3g4NiAqYykge30KIAogI2VuZGlmIC8qIENPTkZJR19YODZfQ1BVX1JFU0NUUkwgKi8KZGlm ZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5lbC9jcHUvcmVzY3RybC9yZHRncm91cC5jIGIvYXJjaC94 ODYva2VybmVsL2NwdS9yZXNjdHJsL3JkdGdyb3VwLmMKaW5kZXggZTJjMTU5OWQxYjM3Li44ODRi NmU5YTdlMzEgMTAwNjQ0Ci0tLSBhL2FyY2gveDg2L2tlcm5lbC9jcHUvcmVzY3RybC9yZHRncm91 cC5jCisrKyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvcmVzY3RybC9yZHRncm91cC5jCkBAIC0zMTQs NyArMzE0LDcgQEAgc3RhdGljIHZvaWQgdXBkYXRlX2NwdV9jbG9zaWRfcm1pZCh2b2lkICppbmZv KQogCSAqIGV4ZWN1dGluZyB0YXNrIG1pZ2h0IGhhdmUgaXRzIG93biBjbG9zaWQgc2VsZWN0ZWQu IEp1c3QgcmV1c2UKIAkgKiB0aGUgY29udGV4dCBzd2l0Y2ggY29kZS4KIAkgKi8KLQlyZXNjdHJs X3NjaGVkX2luKCk7CisJcmVzY3RybF9zY2hlZF9pbihjdXJyZW50KTsKIH0KIAogLyoKQEAgLTUz MCw3ICs1MzAsNyBAQCBzdGF0aWMgdm9pZCBfdXBkYXRlX3Rhc2tfY2xvc2lkX3JtaWQodm9pZCAq dGFzaykKIAkgKiBPdGhlcndpc2UsIHRoZSBNU1IgaXMgdXBkYXRlZCB3aGVuIHRoZSB0YXNrIGlz IHNjaGVkdWxlZCBpbi4KIAkgKi8KIAlpZiAodGFzayA9PSBjdXJyZW50KQotCQlyZXNjdHJsX3Nj aGVkX2luKCk7CisJCXJlc2N0cmxfc2NoZWRfaW4odGFzayk7CiB9CiAKIHN0YXRpYyB2b2lkIHVw ZGF0ZV90YXNrX2Nsb3NpZF9ybWlkKHN0cnVjdCB0YXNrX3N0cnVjdCAqdCkKZGlmZiAtLWdpdCBh L2FyY2gveDg2L2tlcm5lbC9wcm9jZXNzXzMyLmMgYi9hcmNoL3g4Ni9rZXJuZWwvcHJvY2Vzc18z Mi5jCmluZGV4IDQ3MGMxMjg3NTllYS4uNzA4Yzg3Yjg4Y2MxIDEwMDY0NAotLS0gYS9hcmNoL3g4 Ni9rZXJuZWwvcHJvY2Vzc18zMi5jCisrKyBiL2FyY2gveDg2L2tlcm5lbC9wcm9jZXNzXzMyLmMK QEAgLTIxMiw3ICsyMTIsNyBAQCBfX3N3aXRjaF90byhzdHJ1Y3QgdGFza19zdHJ1Y3QgKnByZXZf cCwgc3RydWN0IHRhc2tfc3RydWN0ICpuZXh0X3ApCiAJc3dpdGNoX2ZwdV9maW5pc2goKTsKIAog CS8qIExvYWQgdGhlIEludGVsIGNhY2hlIGFsbG9jYXRpb24gUFFSIE1TUi4gKi8KLQlyZXNjdHJs X3NjaGVkX2luKCk7CisJcmVzY3RybF9zY2hlZF9pbihuZXh0X3ApOwogCiAJcmV0dXJuIHByZXZf cDsKIH0KZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5lbC9wcm9jZXNzXzY0LmMgYi9hcmNoL3g4 Ni9rZXJuZWwvcHJvY2Vzc182NC5jCmluZGV4IDRlMzRiM2I2OGViZC4uYmI2NWE2OGI0YjQ5IDEw MDY0NAotLS0gYS9hcmNoL3g4Ni9rZXJuZWwvcHJvY2Vzc182NC5jCisrKyBiL2FyY2gveDg2L2tl cm5lbC9wcm9jZXNzXzY0LmMKQEAgLTY1Niw3ICs2NTYsNyBAQCBfX3N3aXRjaF90byhzdHJ1Y3Qg dGFza19zdHJ1Y3QgKnByZXZfcCwgc3RydWN0IHRhc2tfc3RydWN0ICpuZXh0X3ApCiAJfQogCiAJ LyogTG9hZCB0aGUgSW50ZWwgY2FjaGUgYWxsb2NhdGlvbiBQUVIgTVNSLiAqLwotCXJlc2N0cmxf c2NoZWRfaW4oKTsKKwlyZXNjdHJsX3NjaGVkX2luKG5leHRfcCk7CiAKIAlyZXR1cm4gcHJldl9w OwogfQo= --000000000000148e7005f655ca63--