From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 868C2C433F5 for ; Tue, 7 Sep 2021 19:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E768610C8 for ; Tue, 7 Sep 2021 19:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232112AbhIGT0G (ORCPT ); Tue, 7 Sep 2021 15:26:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbhIGT0F (ORCPT ); Tue, 7 Sep 2021 15:26:05 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC238C061575 for ; Tue, 7 Sep 2021 12:24:58 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id c8so121449lfi.3 for ; Tue, 07 Sep 2021 12:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1fpdy3b2qMHUETeuDFTFbKg8FYwDRtrIQO5YjCA4iis=; b=gvtqQqQ0P76l17nNx5gKAZmX9q0gXmkKiJplZ5GrV0Rp5D/GmeTFvutVYxXDmohdU0 Rg7GZWtGpo79LRFlloX9NBLbD7hga1UGVHT5sYVxcyx+e++dSBWbGFVZEFJrEiiMD80f lT+vaaeWPC4g7dOg7Pm63HBqJdzPD3ESYM7uY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1fpdy3b2qMHUETeuDFTFbKg8FYwDRtrIQO5YjCA4iis=; b=WdvG8i5pP9ASDpIYyKug4aBuWpU2aO7izofk9u5c/O2NWZOUqQtegVdWg8Rc9ccAt9 PxWDOsbagwDzM+2FRSdjNuCJSh+jMMkKSZIXqI2/NIus8mYa0OhSWkoru4SgClHJNNVu 5um8WZ23twAatNXWSjhcwjPACEX++oHop9UEx7Lzqw3sjpF3z21bw6T0zQyfM6oXycYW 7mc7C9JqP+bLaUQDss/72R+Fao8qTKlhQwHYYJKYg1FrOGdrXP0w6Y1/sC9aLZSKzGaI WuQwI8gfsvWxSRuxw830p2KhZR5sCiL1F3Lfb9vc+dN9HJF8noUjmCRwgntgKhHv+u0K IDMg== X-Gm-Message-State: AOAM531My+xrAjqCrDklGq/LTla7hYUXT0qPR/FFoekcN8BsP9B1fwPY ZhbX8qIYT41Q6ZPX317rjwI7qY60iOG7c+p0nfo= X-Google-Smtp-Source: ABdhPJxUpBxk/daJty2Ih/QfVE8LgqxAmZxCY+S8cXgB/eW57LqrC9eIprsHII5wywZxWTy4oU+Ahg== X-Received: by 2002:a19:fc0d:: with SMTP id a13mr16433lfi.92.1631042696989; Tue, 07 Sep 2021 12:24:56 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id q18sm1529224ljm.50.2021.09.07.12.24.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Sep 2021 12:24:56 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id g14so298566ljk.5 for ; Tue, 07 Sep 2021 12:24:56 -0700 (PDT) X-Received: by 2002:a05:6512:3da5:: with SMTP id k37mr14175340lfv.655.1631042198154; Tue, 07 Sep 2021 12:16:38 -0700 (PDT) MIME-Version: 1.0 References: <20210907183843.33028-1-ndesaulniers@google.com> In-Reply-To: <20210907183843.33028-1-ndesaulniers@google.com> From: Linus Torvalds Date: Tue, 7 Sep 2021 12:16:22 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Revert "Enable '-Werror' by default for all kernel builds" To: Nick Desaulniers Cc: llvm@lists.linux.dev, LSM List , linux-toolchains@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Kees Cook , Mark Brown , Masahiro Yamada , Nathan Chancellor , Michal Marek , Andrew Morton , Vipin Sharma , Chris Down , Rasmus Villemoes , Daniel Borkmann , Vlastimil Babka , Linux Kbuild mailing list , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On Tue, Sep 7, 2021 at 11:39 AM Nick Desaulniers wrote: > > The above commit seems as though it was merged in response to > https://lore.kernel.org/linux-hardening/CAHk-=wj4EG=kCOaqyPEq5VXa97kyUHsBpBn3DWwE91qcnDytOQ@mail.gmail.com/. No. It was merged in response of _years_ of pain, with the last one just being the final drop. I'm not going to revert that change. I probably will have to limit it (by making that WERROR option depend on certain expectations), but basically any maintainer who has code that causes warnings should expect that they will have to fix those warnings. If it's clang that generates bogus warnings, then we'll have to start disable clang warnings. The clang people tend to be proud of thir fewer false positives, but so far looking at things, I am not convinced. And I'm most definitely not convinced when the "let's finally enable -Werror after years of talking about it", people end up going "but but but I have thousands of warnings". That's the POINT of that commit. That "but but but I have thousands of warnings" is not acceptable. I spent hours yesterday getting rid of some warnings. It shouldn't be on me fixing peoples code. It shouldn't be on me noticing that people send me crap that warns. And it really shouldn't be "Linus cares about warnings, so configurations that Linus doesn't test can continue for years to have them". My "no warnings" policy isn't exactly new, and people shouldn't be shocked when I then say "time to clean up *YOUR* house too". Linus