From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A29C4332F for ; Wed, 21 Dec 2022 18:46:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233664AbiLUSqb (ORCPT ); Wed, 21 Dec 2022 13:46:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234871AbiLUSq3 (ORCPT ); Wed, 21 Dec 2022 13:46:29 -0500 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A0ACFAD2 for ; Wed, 21 Dec 2022 10:46:28 -0800 (PST) Received: by mail-qt1-x82f.google.com with SMTP id c11so6514911qtn.11 for ; Wed, 21 Dec 2022 10:46:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0sODeRBjvPETeUrYPz7JbnedMQB/IxCocAx1FoaszTU=; b=Wy0Sz3Rojhc+tOVGf8KvjRmRjEZJqCHd1i96YwhlFe4AQJBhrynZfO6wMunqOJzcXp OtAxmPiWamNa669nglrJtYL1LY751fImTMMRlSeC3y0bx2EEI6E+E52yb1KBO5mdAHbC maEreRZaysRS4E6MKmemJDVUZ/OrXE9mHf/EU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0sODeRBjvPETeUrYPz7JbnedMQB/IxCocAx1FoaszTU=; b=MGyBjI2urDaPiFsDVffWKLKAAKx8mKzDfFHGBueqDGeYoYDQjvYidrFS8yAaXw9qQv f0pPZOj0PbQKcg2umTDQALzhX/31aBe+o2NCacTCnEo3H9huxFO0FZqxRT4S+H+CkgIK 4sbrSRyzlTeqa1ZGfVDdG6X9qooMv3PS/d6A1mgioSMaYibtSuGFGBz7qPE0TkPzJKeZ sGNRAuCMxInYOrV9/jVGlpkaT3Paxp1xgDvwOmnwx6nGWJcsFTvZDdQ3AZkiCnZXeAPm eiqX6xBIvrNmLTMrsAXApsppoVCdaaVcBoRwueapXaYirXp2Gnzv4mXc1lkiwICNxFqI cHGA== X-Gm-Message-State: AFqh2kpD7wnHsobHl5Us5PnHbEabNV1bIxS4nXCc89FX9GD+dgrTfJsE i3/MUGj7b2uXRJmqPs+8JkAW/ajkTmAl7I0Q X-Google-Smtp-Source: AMrXdXvKYadBE/1zSlep1KvfaylxgoaFcv9CVG2H7wiMJS2yJAeuAawK/HidG1eQ3kHCC6t+5wDVng== X-Received: by 2002:ac8:1287:0:b0:3a8:23d4:8d2b with SMTP id y7-20020ac81287000000b003a823d48d2bmr3473042qti.10.1671648387543; Wed, 21 Dec 2022 10:46:27 -0800 (PST) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com. [209.85.160.170]) by smtp.gmail.com with ESMTPSA id c144-20020ae9ed96000000b006fb11eee465sm11080493qkg.64.2022.12.21.10.46.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 10:46:25 -0800 (PST) Received: by mail-qt1-f170.google.com with SMTP id fu10so14434361qtb.0 for ; Wed, 21 Dec 2022 10:46:24 -0800 (PST) X-Received: by 2002:ac8:4e26:0:b0:3a7:648d:23d4 with SMTP id d6-20020ac84e26000000b003a7648d23d4mr140158qtw.180.1671648384706; Wed, 21 Dec 2022 10:46:24 -0800 (PST) MIME-Version: 1.0 References: <20221019203034.3795710-1-Jason@zx2c4.com> <20221221145332.GA2399037@roeck-us.net> <1a27385c-cca6-888b-1125-d6383e48c0f5@prevas.dk> <20221221155641.GB2468105@roeck-us.net> <20221221171922.GA2470607@roeck-us.net> In-Reply-To: <20221221171922.GA2470607@roeck-us.net> From: Linus Torvalds Date: Wed, 21 Dec 2022 10:46:08 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] kbuild: treat char as always unsigned To: Guenter Roeck Cc: Rasmus Villemoes , Geert Uytterhoeven , "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, linux-toolchains@vger.kernel.org, Masahiro Yamada , Kees Cook , Andrew Morton , Andy Shevchenko , Greg Kroah-Hartman , linux-m68k@lists.linux-m68k.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org On Wed, Dec 21, 2022 at 9:19 AM Guenter Roeck wrote: > > On Wed, Dec 21, 2022 at 09:06:41AM -0800, Linus Torvalds wrote: > > > > I think the real fix is to just remove that broken implementation > > entirely, and rely on the generic one. > > Perfectly fine with me. That got pushed out as commit 7c0846125358 ("m68k: remove broken strcmp implementation") but it's obviously entirely untested. I don't do m68k cross-compiles, much less boot tests. Just FYI for everybody - I may have screwed something up for some very non-obvious reason. But it looked very obvious indeed, and I hate having buggy code that is architecture-specific when we have generic code that isn't buggy. Linus