linux-toolchains.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	linux-toolchains@vger.kernel.org
Subject: Re: [PATCH] sched: Work around undefined behavior in sched class checking
Date: Wed, 5 May 2021 10:08:03 -0700	[thread overview]
Message-ID: <CAKwvOd=jrmFxNMJzbMYbSYs7C6S1d7faOj-R60ZhpV50PNTdbw@mail.gmail.com> (raw)
In-Reply-To: <a4d64648-6726-2046-0883-ac7f20c70445@linux.intel.com>

On Wed, May 5, 2021 at 9:49 AM Andi Kleen <ak@linux.intel.com> wrote:
>
>
> On 5/5/2021 9:41 AM, Nick Desaulniers wrote:
> > On Wed, May 5, 2021 at 7:39 AM Andi Kleen <ak@linux.intel.com> wrote:
> >>>   Would you please provide a
> >>> minimal test case?
> >> You can only reproduce it with a LTO build because it needs knowledge
> >> between different translation units for this specific case.
> >>
> >> But gcc will totally do the optimization even without LTO if it can
> >> prove the same inside a single TU.
> > It would be helpful to isolate a test case that doesn't rely on LTO,
> > if possible.
>
> Like I wrote earlier we used to see it all the time in __pa_symbol
> before it used RELOC_HIDE. I bet if you make RELOC_HIDE a nop you'll see
> multiple instances.
>
> But not sure why you want a test case?

In general,
when making a feature request to a compiler vendor, having a
digestible snippet of code that demonstrates the problem goes a long
way, much further than "clone this branch of my fork of this project
and do a build and something goes wrong somewhere."  We're too busy to
do that, please take the time to isolate it before making such
requests.

-- 
Thanks,
~Nick Desaulniers

  reply	other threads:[~2021-05-05 17:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210505033945.1282851-1-ak@linux.intel.com>
2021-05-05  6:46 ` [PATCH] sched: Work around undefined behavior in sched class checking Peter Zijlstra
2021-05-05  8:47   ` Florian Weimer
2021-05-05  9:04     ` Peter Zijlstra
2021-05-05 14:39     ` Andi Kleen
2021-05-05 16:41       ` Nick Desaulniers
2021-05-05 16:48         ` Andi Kleen
2021-05-05 17:08           ` Nick Desaulniers [this message]
2021-05-05 17:20             ` Andi Kleen
2021-05-05 14:34   ` Andi Kleen
2021-05-05 15:34     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKwvOd=jrmFxNMJzbMYbSYs7C6S1d7faOj-R60ZhpV50PNTdbw@mail.gmail.com' \
    --to=ndesaulniers@google.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=fweimer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-toolchains@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).