From: Nick Desaulniers <ndesaulniers@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Jakub Jelinek <jakub@redhat.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
Peter Zijlstra <peterz@infradead.org>,
"Eranian, Stephane" <eranian@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
"peternewman@google.com" <peternewman@google.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"babu.moger@amd.com" <babu.moger@amd.com>,
"ananth.narayan@amd.com" <ananth.narayan@amd.com>,
"vschneid@redhat.com" <vschneid@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
"linux-toolchains@vger.kernel.org"
<linux-toolchains@vger.kernel.org>
Subject: Re: [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in
Date: Tue, 7 Mar 2023 13:22:45 -0800 [thread overview]
Message-ID: <CAKwvOdk1n2v5Sym14BR0jGWKX8nNP1VL4Z1vXtAOWvQETOCSmQ@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wiVP8ezgCyBTq3GV-1ebiOf03Qo_iHnVAR08NJO0jOocg@mail.gmail.com>
On Tue, Mar 7, 2023 at 1:19 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Tue, Mar 7, 2023 at 1:16 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
> >
> > >
> > > Can you expand about part "a" ... Linux has zillions of static inline functions
> > > in header files to handle CONFIG options. One version is the real McCoy
> > > while the other is just a stub for the CONFIG=n case.
> >
> > Right, I had the same question.
> >
> > Perhaps it's more so that no one calls __resctrl_sched_in, only
> > resctrl_sched_in, therefor they should be folded into one function?
>
> If you think it should be inlined, it should be marked as such.
Yep, sorry, I missed that `inline` was missing from that definition!
>
> And if you *don't* think it should be inlined - quite possibly the
> right answer here - the definition of that function damn well
> shouldn't be in a header file.
>
> So either way, that __resctrl_sched_in() was wrong, wrong, wrong.
>
> Linus
>
--
Thanks,
~Nick Desaulniers
prev parent reply other threads:[~2023-03-07 21:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230303231133.1486085-1-eranian@google.com>
[not found] ` <20230306120106.GE1267364@hirez.programming.kicks-ass.net>
[not found] ` <CAKwvOdnRvd5KK01awAyeyt5S36TPPW4_8Z6YL1r4gB-pBrHTbg@mail.gmail.com>
2023-03-07 11:35 ` [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in Peter Zijlstra
2023-03-07 17:48 ` Linus Torvalds
2023-03-07 18:43 ` Segher Boessenkool
2023-03-07 20:43 ` Jakub Jelinek
2023-03-07 20:54 ` Linus Torvalds
2023-03-07 21:06 ` Linus Torvalds
2023-03-07 21:35 ` Luck, Tony
2023-03-07 21:58 ` Nick Desaulniers
2023-03-08 6:13 ` Stephane Eranian
2023-03-08 23:25 ` Linus Torvalds
2023-03-08 16:02 ` Moger, Babu
2023-03-07 21:11 ` Luck, Tony
2023-03-07 21:14 ` Linus Torvalds
2023-03-07 21:23 ` Luck, Tony
2023-03-08 0:36 ` Luck, Tony
2023-03-07 21:16 ` Nick Desaulniers
2023-03-07 21:19 ` Linus Torvalds
2023-03-07 21:22 ` Nick Desaulniers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdk1n2v5Sym14BR0jGWKX8nNP1VL4Z1vXtAOWvQETOCSmQ@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=ananth.narayan@amd.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jakub@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=segher@kernel.crashing.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).