archive mirror
 help / color / mirror / Atom feed
From: Nick Desaulniers <>
To: Peter Zijlstra <>,
	Masahiro Yamada <>,
	Josh Poimboeuf <>
Cc: Michal Marek <>,
	Linux Kernel Mailing List <>,
	Linux Kbuild mailing list <>,
	Sam Ravnborg <>, X86 ML <>,
	Arnd Bergmann <>,
	Changbin Du <>,,
	clang-built-linux <>
Date: Fri, 8 Apr 2022 13:16:35 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Apr 8, 2022 at 1:08 PM Nick Desaulniers <> wrote:
> Lore thread start for newly cc'ed ML readers:
> On Fri, Apr 8, 2022 at 12:14 PM Peter Zijlstra <> wrote:
> >
> > This weird option is having us upgrade quite a few 'inline' to
> > '__always_inline'.
> As is, the assumption that __init functions only call other __init
> functions or __always_inline is a brittle house of cards that leads to
> a "what color is your function" [0] scenario, and leads to code that
> happens to not emit warnings for compiler X (or compiler X version Y).
> There's also curious exceptions in modpost that look like memory leaks
> to me.

These assumptions perhaps made more sense in a world prior to
commit 889b3c1245de ("compiler: remove CONFIG_OPTIMIZE_INLINING entirely")

(I view 889b3c1245de favorably; perhaps this whole thread is just
fallout from that change though.  It's also interesting to note that
CONFIG_OPTIMIZE_INLINING was enabled in the i386 and x86_64
defconfigs. That might color some folk's experience with the use of
`inline` in the kernel sources and whether "inline means
~Nick Desaulniers

  reply	other threads:[~2022-04-08 20:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
     [not found] ` <>
     [not found]   ` <>
2022-04-08 20:08     ` [PATCH] kbuild: Remove CONFIG_DEBUG_SECTION_MISMATCH Nick Desaulniers
2022-04-08 20:16       ` Nick Desaulniers [this message]
2022-04-08 20:32       ` Peter Zijlstra
2022-04-08 20:48         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).