From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FEFCC25B48 for ; Thu, 26 Oct 2023 19:37:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229668AbjJZThp (ORCPT ); Thu, 26 Oct 2023 15:37:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231766AbjJZThp (ORCPT ); Thu, 26 Oct 2023 15:37:45 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7737C121; Thu, 26 Oct 2023 12:37:43 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E91E6C433C8; Thu, 26 Oct 2023 19:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698349063; bh=uvyIqOBKNfkFHe0q/wlli3JBnyltBarFakFaKmvDmFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XrQsUwHnBd2TcXUEDuaqTNHZ1Hp9O8Hws1njlwmYTNGZfI6KqoNWhSB0i3NBasXkd p1V/M80GAPwhhHBshBMFU0rFFB+LTiSxD6+9cqfiu5T7mDbW587X/fE4vBoMgB5fUR jthL2hlDcon2dyul3HJ8W7XI9yIkYVKCchyfSDjhOkKkYRD7d1mR4Lw84sqquCTGHA LyMQ+lqbS1G8A2u5yq7Bk6i6LssU+2PGxHu6/Nm9QCohVFx29ivMi7boKa55TOhgyF ChlcVVz166XfVf7tisa77/G6bUoR6plUb9gwKbf8dHu9pjX10l3/c0YWtETHbMtN7d 2+ICEayNhHpYg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D93054035D; Thu, 26 Oct 2023 16:37:39 -0300 (-03) Date: Thu, 26 Oct 2023 16:37:39 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Jiri Olsa , Peter Zijlstra , Ian Rogers , Adrian Hunter , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Linus Torvalds , Stephane Eranian , Masami Hiramatsu , linux-toolchains@vger.kernel.org, linux-trace-devel@vger.kernel.org Subject: Re: [PATCH 13/48] perf annotate: Add annotate_get_insn_location() Message-ID: References: <20231012035111.676789-1-namhyung@kernel.org> <20231012035111.676789-14-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-toolchains@vger.kernel.org Em Wed, Oct 25, 2023 at 10:26:32PM -0700, Namhyung Kim escreveu: > On Tue, Oct 24, 2023 at 12:10 PM Namhyung Kim wrote: > > On Mon, Oct 23, 2023 at 9:38 AM Arnaldo Carvalho de Melo wrote: > > > Em Wed, Oct 11, 2023 at 08:50:36PM -0700, Namhyung Kim escreveu: > > > > The annotate_get_insn_location() is to get the detailed information of > > > > instruction locations like registers and offset. It has source and > > > > target operands locations in an array. Each operand can have a > > > > register and an offset. The offset is meaningful when mem_ref flag is > > > > set. > > > This needs to be enclosed in HAVE_DWARF_SUPPORT, as the build is failing > > > in systems where this isn't available, see patch below. > > Thanks for the test and the patch, will add it to v2. > Hmm.. I think this function can work without DWARF. > If the only problem is get_dwarf_regnum() probably > I can add a dummy function when libdw is not found. > Maybe I need to use arch reg number here and > convert to DWARF later. That can be a possibility, but the interesting thing is to try to run 'make -C tools/perf build-test' regularly to catch these builds without some of the components, I bet this one: make_no_libelf := NO_LIBELF=1 As my container builds did, as that is one of the things built there. One other suggestion would be to add some warning when the required components to build the data profiling feature are not present. - Arnaldo