From: "Moger, Babu" <babu.moger@amd.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Jakub Jelinek <jakub@redhat.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Peter Zijlstra <peterz@infradead.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Stephane Eranian <eranian@google.com>,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
reinette.chatre@intel.com, fenghua.yu@intel.com,
peternewman@google.com, james.morse@arm.com,
ananth.narayan@amd.com, vschneid@redhat.com,
Nathan Chancellor <nathan@kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
linux-toolchains@vger.kernel.org
Subject: Re: [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in
Date: Wed, 8 Mar 2023 10:02:46 -0600 [thread overview]
Message-ID: <d0d7b726-7149-9982-e63e-8549dea8f915@amd.com> (raw)
In-Reply-To: <CAHk-=whCA4-uc5WV_-68Mpmu-TiSv6fxkSjZ19zzcW9jpSxDvA@mail.gmail.com>
On 3/7/23 15:06, Linus Torvalds wrote:
> On Tue, Mar 7, 2023 at 12:54 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> I think the problem is that the <asm/resctrl.h> code is disgusting and
>> horrible in multiple ways:
>>
>> (a) it shouldn't define and declare a static function in a header file
>>
>> (b) the resctrl_sched_in() inline function is misdesigned to begin with
>
> Ok, so here's a *ttoally* untested and mindless patch to maybe fix
> what I dislike about that resctl code.
>
> Does it fix the code generation issue? I have no idea. But this is
> what I would suggest is the right answer, without actually knowing the
> code any better, and just going on a mindless rampage.
>
> It seems to compile for me, fwiw.
>
> Linus
Tested both on GCC and CLANG. Test passes and resctrl limits are working
fine. Thanks for the patch.
Tested-by: Babu Moger <babu.moger@amd.com>
--
Thanks
Babu Moger
next prev parent reply other threads:[~2023-03-08 16:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230303231133.1486085-1-eranian@google.com>
[not found] ` <20230306120106.GE1267364@hirez.programming.kicks-ass.net>
[not found] ` <CAKwvOdnRvd5KK01awAyeyt5S36TPPW4_8Z6YL1r4gB-pBrHTbg@mail.gmail.com>
2023-03-07 11:35 ` [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in Peter Zijlstra
2023-03-07 17:48 ` Linus Torvalds
2023-03-07 18:43 ` Segher Boessenkool
2023-03-07 20:43 ` Jakub Jelinek
2023-03-07 20:54 ` Linus Torvalds
2023-03-07 21:06 ` Linus Torvalds
2023-03-07 21:35 ` Luck, Tony
2023-03-07 21:58 ` Nick Desaulniers
2023-03-08 6:13 ` Stephane Eranian
2023-03-08 23:25 ` Linus Torvalds
2023-03-08 16:02 ` Moger, Babu [this message]
2023-03-07 21:11 ` Luck, Tony
2023-03-07 21:14 ` Linus Torvalds
2023-03-07 21:23 ` Luck, Tony
2023-03-08 0:36 ` Luck, Tony
2023-03-07 21:16 ` Nick Desaulniers
2023-03-07 21:19 ` Linus Torvalds
2023-03-07 21:22 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0d7b726-7149-9982-e63e-8549dea8f915@amd.com \
--to=babu.moger@amd.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jakub@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=segher@kernel.crashing.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).