From: Yordan Karadzhov <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>, linux-trace-devel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Tom Zanussi <zanussi@kernel.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH 1/2] libtracefs: Add random number to keep synthetic variables unique
Date: Thu, 12 Aug 2021 11:34:57 +0300 [thread overview]
Message-ID: <13bed3a6-7e39-eec2-2421-a80081302a81@gmail.com> (raw)
In-Reply-To: <20210812005546.910833-2-rostedt@goodmis.org>
On 12.08.21 г. 3:55, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> The 'hist' triggers expect that all variables are unique. If two synthetic
> events are created, it is possible that they will use the same variable
> names, and this can break the logic for synthetic events. Add a random
> number to the argument names that will help prevent that from happening.
> There's no guarantee that there wont be collisions, but the chances of
> that happening is 1 in 65535. If this is a problem, we could possibly look
> for variables that are already in use.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> src/tracefs-hist.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/src/tracefs-hist.c b/src/tracefs-hist.c
> index 7f9cf3820611..8783ef4364bd 100644
> --- a/src/tracefs-hist.c
> +++ b/src/tracefs-hist.c
> @@ -13,6 +13,8 @@
> #include <errno.h>
> #include <fcntl.h>
> #include <limits.h>
> +#include <time.h>
> +#include <sys/types.h>
>
> #include "tracefs.h"
> #include "tracefs-local.h"
> @@ -558,6 +560,7 @@ struct tracefs_synth {
> unsigned int end_parens;
> unsigned int end_state;
> int *start_type;
> + char arg_name[16];
> int arg_cnt;
> };
>
> @@ -957,7 +960,15 @@ static char *new_arg(struct tracefs_synth *synth)
> char *arg;
> int ret;
>
> - ret = asprintf(&arg, "__arg__%d", cnt);
> + /* Create a unique argument name */
> + if (!synth->arg_name[0]) {
> + srand(time(NULL));
Nit: Have in mind that time(NULL) has 1 second resolution. Fast consecutive calls (within a second) of this function can
generate identical random numbers.
This can be mitigated if we do something like this:
struct timeval now;
gettimeofday(&now, NULL);
srand(now.tv_usec);
-- Yordan
> + ret = rand() + gettid();
> + /* Truncate so that ret is at most 65535 (total 13 bytes) */
> + ret &= (1 << 16) - 1;
> + sprintf(synth->arg_name, "__arg_%d_", ret);
> + }
> + ret = asprintf(&arg, "%s%d", synth->arg_name, cnt);
> if (ret < 0)
> return NULL;
>
>
next prev parent reply other threads:[~2021-08-12 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 0:55 [PATCH 0/2] libtracefs: Make hist variable names unique Steven Rostedt
2021-08-12 0:55 ` [PATCH 1/2] libtracefs: Add random number to keep synthetic variables unique Steven Rostedt
2021-08-12 8:34 ` Yordan Karadzhov [this message]
2021-08-12 14:00 ` Steven Rostedt
2021-08-12 0:55 ` [PATCH 2/2] libtracefs: Have end event variables not be the end event field name Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13bed3a6-7e39-eec2-2421-a80081302a81@gmail.com \
--to=y.karadz@gmail.com \
--cc=bristot@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).