From: vincent.donnefort@arm.com
To: linux-trace-devel@vger.kernel.org
Cc: Vincent Donnefort <vincent.donnefort@arm.com>
Subject: [PATCH] trace-cmd: fix extract output option
Date: Tue, 29 Sep 2020 18:49:26 +0100 [thread overview]
Message-ID: <1601401766-54400-1-git-send-email-vincent.donnefort@arm.com> (raw)
From: Vincent Donnefort <vincent.donnefort@arm.com>
During the introduction of instance's output_file copy:
3a206ca ("trace-cmd: Have instances include a copy of its output file")
The extract path has been omitted, leading to a broken output option:
$ trace-cmd extract -o /foo/bar.dat # Will fallback to ./trace.dat
Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index bd00457..72a5c8c 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -6622,6 +6622,9 @@ void trace_extract(int argc, char **argv)
/* Save the state of tracing_on before starting */
for_all_instances(instance) {
+ instance->output_file = strdup(ctx.output);
+ if (!instance->output_file)
+ die("Failed to allocate output file name for instance");
if (!ctx.manual && instance->flags & BUFFER_FL_PROFILE)
enable_profile(ctx.instance);
--
2.7.4
next reply other threads:[~2020-09-29 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 17:49 vincent.donnefort [this message]
2020-09-29 20:31 ` [PATCH] trace-cmd: fix extract output option Steven Rostedt
2020-09-30 8:31 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1601401766-54400-1-git-send-email-vincent.donnefort@arm.com \
--to=vincent.donnefort@arm.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).