linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 5/8] kernel-shark-qt: Create "Apply filter XX" checkboxes in KsUtils
Date: Mon, 17 Dec 2018 19:44:03 +0200	[thread overview]
Message-ID: <19a2b689-b316-a759-b626-3a5aed4d1a87@gmail.com> (raw)
In-Reply-To: <20181214120155.706a68aa@gandalf.local.home>



On 14.12.18 г. 19:01 ч., Steven Rostedt wrote:
> On Fri, 14 Dec 2018 12:52:39 +0000
> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
> 
>> The code responsible for the creation of the "Apply filters to Graph"
>> and "Apply filters to List" checkboxes (showing in the "Filtering" menu),
>> has been moved outside of the KsMainWindow class and is now available
>> in KsUtils. This is done because we want to have the same checkboxes
>> available in the KsQuickContextMenu.
>>
> 
> I applied this patch and it shows the "Hide CPU [x]". But it's a bit
> flaky. The first time I tried it, it didn't do anything. Then after
> starting kernelshark again, I was able to have it hide the CPU, but
> when I clicked on the "Filter" menu on the top toolbar, the filter went
> away.

Interesting, I have an idea why this may happen, but I am not sure.


> 
> Another thing, the "Apply filters to Graph" checkbox is a bit
> confusing. What does it actually mean? The filters are applied by
> default to the graph, correct? But the checkbox isn't set.
> 
> Also, does it make sense to have that "Apply filters to graph" checkbox
> in the Graph menu. It would make more sense if it said "Apply filters
> to table".

You are right. There is a typo in the name of the checkbox. But it does 
the correct thing.

I will fix the two problems and will resend the patch.

Thanks a lot!
Yordan


> 
> I think I'll apply this series except for this patch and the last one
> (5 and 8).
> 
> -- Steve
> 

  reply	other threads:[~2018-12-17 17:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 12:52 [PATCH v2 0/8] More modifications toward KS 1.0 Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 1/8] kernel-shark-qt: Lock completely the searching panel when searching Yordan Karadzhov
2018-12-14 14:50   ` Steven Rostedt
2018-12-14 14:52     ` Steven Rostedt
2018-12-14 12:52 ` [PATCH v2 2/8] kernel-shark-qt: Fix a simple bug in KsTraceViewer::_searchReset() Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 3/8] kernel-shark-qt: Make the parallelized search stoppable Yordan Karadzhov
2018-12-14 17:17   ` Steven Rostedt
2018-12-17 17:02     ` Yordan Karadzhov (VMware)
2018-12-14 12:52 ` [PATCH v2 4/8] kernel-shark-qt: Avoid spurious searches Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 5/8] kernel-shark-qt: Create "Apply filter XX" checkboxes in KsUtils Yordan Karadzhov
2018-12-14 17:01   ` Steven Rostedt
2018-12-17 17:44     ` Yordan Karadzhov (VMware) [this message]
2018-12-14 12:52 ` [PATCH v2 6/8] kernel-shark-qt: Improve the KsQuickContextMenu Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 7/8] kernel-shark-qt: Update the documentation link Yordan Karadzhov
2018-12-14 12:52 ` [PATCH v2 8/8] kernel-shark-qt: Version 1.0.0 Yordan Karadzhov
2018-12-14 17:10 ` [PATCH v2 0/8] More modifications toward KS 1.0 Steven Rostedt
2018-12-17 17:11   ` Yordan Karadzhov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19a2b689-b316-a759-b626-3a5aed4d1a87@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).