From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org" <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v3 02/15] tools/lib/traceevent: Added support for pkg-config
Date: Wed, 28 Nov 2018 15:14:59 -0500 [thread overview]
Message-ID: <20181128151459.4f351a5d@gandalf.local.home> (raw)
In-Reply-To: <20181128090711.17792-3-tstoyanov@vmware.com>
On Wed, 28 Nov 2018 09:07:30 +0000
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
> +PKG_CONFIG_FILE = libtraceevent.pc
> +define do_install_pkgconfig_file
> + if [ -n "${pkgconfig_dir}" ]; then \
> + cp -f ${PKG_CONFIG_FILE}.template ${PKG_CONFIG_FILE}; \
> + sed -i "s|INSTALL_PREFIX|${1}|g" ${PKG_CONFIG_FILE}; \
> + sed -i "s|LIB_VERSION|${EVENT_PARSE_VERSION}|g" ${PKG_CONFIG_FILE}; \
> + $(call do_install,$(PKG_CONFIG_FILE),$(pkgconfig_dir),644); \
> + else \
> + (echo Failed to locate pkg-config directory) 1>&2; \
> + fi
Might want to run checkpatch.pl before sending, as it can catch
whitespace issues. The above "fi" has a tab after it.
$ ./scripts/checkpatch.pl mbox.patch
ERROR: trailing whitespace
#139: FILE: tools/lib/traceevent/Makefile:285:
+^Ifi^I$
> +endef
next prev parent reply other threads:[~2018-11-29 7:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:07 [PATCH v3 00/15] tools/lib/traceevent,tools/perf: Various changes in libtraceevent APIs Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 01/15] tools/lib/traceevent: Implemented new API tep_get_ref() Tzvetomir Stoyanov
2018-11-28 20:01 ` Steven Rostedt
2018-11-28 9:07 ` [PATCH v3 02/15] tools/lib/traceevent: Added support for pkg-config Tzvetomir Stoyanov
2018-11-28 20:14 ` Steven Rostedt [this message]
2018-11-28 20:15 ` Steven Rostedt
2018-11-28 9:07 ` [PATCH v3 03/15] tools/lib/traceevent: Install trace-seq.h API header file Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 04/15] tools/lib/traceevent, tools/perf: Rename struct tep_event_format to struct tep_event Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 05/15] tools/lib/traceevent: Rename tep_free_format() to tep_free_event() Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 06/15] tools/perf: traceevent API cleanup, remove __tep_data2host*() Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 07/15] tools/lib/traceevent: traceevent API cleanup Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 08/15] tools/lib/traceevent: Introduce new libtracevent API: tep_override_comm() Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 09/15] tools/lib/traceevent: Initialize host_bigendian at tep_handle allocation Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 10/15] tools/lib/traceevent: Rename struct cmdline to struct tep_cmdline Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 11/15] tools/lib/traceevent: Changed return logic of trace_seq_printf() and trace_seq_vprintf() APIs Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 12/15] tools/lib/traceevent: Changed return logic of tep_register_event_handler() API Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 13/15] tools/lib/traceevent: Rename tep_is_file_bigendian() to tep_file_bigendian() Tzvetomir Stoyanov
2018-11-28 9:07 ` [PATCH v3 14/15] tools/lib/traceevent: Change description of few APIs Tzvetomir Stoyanov
2018-12-01 3:43 ` Steven Rostedt
2018-12-01 3:58 ` Steven Rostedt
2019-03-13 15:56 ` Steven Rostedt
2018-11-28 9:07 ` [PATCH v3 15/15] tools/lib/traceevent: Remove tep_data_event_from_type() API Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128151459.4f351a5d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).