From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov <y.karadz@gmail.com>
Subject: Re: [PATCH v3 3/3] trace-cmd: Fix record --date flag when sending tracing data to a listener
Date: Thu, 13 Dec 2018 20:38:52 -0500 [thread overview]
Message-ID: <20181213203852.5989aa28@vmware.local.home> (raw)
In-Reply-To: <20181212111711.30990a0f@gandalf.local.home>
On Wed, 12 Dec 2018 11:17:11 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> Let's break this function up, and have the caller deal with a
> tracecmd_output *handle.
>
> We can have:
>
> handle = tracecmd_get_output_handle_fd(ofd);
> if (write_options) {
> tracecmd_write_cpus(handle, cpus);
> tracecmd_write_options(handle);
> }
> tracecmd_write_cpu_data(handle, cpus, temp_files);
>
> Also, let's have this patch come before patch 2/3, such that there's no
> path to write the options until the boosting to v3.
Hi Slavomir,
Have you had a chance to do these changes yet and send out a v4?
Thanks,
-- Steve
prev parent reply other threads:[~2018-12-14 1:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 9:15 [PATCH v3 0/3] trace-cmd: Resend record --date fix Slavomir Kaslev
2018-12-05 9:15 ` [PATCH v3 1/3] trace-cmd: Prepare for protocol bump to version 3 Slavomir Kaslev
2018-12-05 9:15 ` [PATCH v3 2/3] trace-cmd: Bump protocol version to v3 Slavomir Kaslev
2018-12-05 9:15 ` [PATCH v3 3/3] trace-cmd: Fix record --date flag when sending tracing data to a listener Slavomir Kaslev
2018-12-12 16:17 ` Steven Rostedt
2018-12-14 1:38 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213203852.5989aa28@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).