Linux-Trace-Devel Archive on
 help / Atom feed
* [PATCH 05/63] tools lib traceevent: Fix processing of dereferenced args in bprintk events
       [not found] <>
@ 2018-12-18 22:06 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 1+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-12-18 22:06 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Clark Williams, linux-kernel, linux-perf-users,
	Steven Rostedt (VMware),
	Jiri Olsa, Namhyung Kim, linux-trace-devel, stable,
	Arnaldo Carvalho de Melo

From: "Steven Rostedt (VMware)" <>

In the case that a bprintk event has a dereferenced pointer that is
stored as a string, and there's more values to process (more args), the
arg was not updated to point to the next arg after processing the
dereferenced pointer, and it screwed up what was to be displayed.

Signed-off-by: Steven Rostedt (VMware) <>
Cc: Jiri Olsa <>
Cc: Namhyung Kim <>
Fixes: 37db96bb49629 ("tools lib traceevent: Handle new pointer processing of bprint strings")
Signed-off-by: Arnaldo Carvalho de Melo <>
 tools/lib/traceevent/event-parse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index a5ed291b8a9f..69a96e39f0ab 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4973,6 +4973,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct tep_e
 				if (arg->type == TEP_PRINT_BSTRING) {
 					trace_seq_puts(s, arg->string.string);
+					arg = arg->next;

^ permalink raw reply	[flat|nested] 1+ messages in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <>
2018-12-18 22:06 ` [PATCH 05/63] tools lib traceevent: Fix processing of dereferenced args in bprintk events Arnaldo Carvalho de Melo

Linux-Trace-Devel Archive on

Archives are clonable:
	git clone --mirror linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ \
	public-inbox-index linux-trace-devel

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox