From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH] Fix formatting of fixed-point numbers to not skip zeros
Date: Fri, 11 Jan 2019 10:24:20 +0100 [thread overview]
Message-ID: <20190111092420.e24fxhyke2o5vnp3@pengutronix.de> (raw)
In-Reply-To: <900152eb-ce31-0918-7675-17729f0cfbe9@vmware.com>
Hello Yordan,
On Fri, Jan 11, 2019 at 09:09:19AM +0000, Yordan Karadzhov wrote:
> On 10.01.19 г. 23:48 ч., Steven Rostedt wrote:
> > On Thu, 10 Jan 2019 22:43:46 +0100
> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> >
> >> When a timestamp that represents 1.00001 is converted to (for example)
> >> seconds and microseconds this results in seconds=1 and useconds=10. To
> >> format that into a string requires the format %lu.%06lu to yield
> >> "1.000010". Some code parts used %lu.%lu however which results in "1.10"
> >> which is wrong.
> >
> > Thanks Uwe!
> >
> > Yordan, can you review this patch and give an Acked-by or Reviewed-by
> > tag?
>
> Very well spotted.
>
> Reviewed-by: Yordan Karadzhov <ykaradzhov@vmware.com>
>
> Just one minor thing, please sign the patch.
It was a conscious decision to not sign-off the patch as it isn't
formalized for trace-cmd what a Signed-off-by-line would mean.
So if you insist on this formalism, I suggest you formalize it first :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-01-11 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 21:43 [PATCH] Fix formatting of fixed-point numbers to not skip zeros Uwe Kleine-König
2019-01-10 21:48 ` Steven Rostedt
2019-01-11 9:09 ` Yordan Karadzhov
2019-01-11 9:24 ` Uwe Kleine-König [this message]
2019-01-11 14:29 ` Steven Rostedt
2019-01-11 15:05 ` [PATCH v2] " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111092420.e24fxhyke2o5vnp3@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).