Re: [PATCH v2] plugin python: Adjust the handling after PyRun_String() failed

Re: [PATCH v2] plugin python: Adjust the handling after PyRun_String() failed

[Steven Rostedt]

On Thu, 27 Apr 2017 11:55:58 +0900
Taeung Song <treeze.taeung@gmail.com> wrote:

> Even though PyRun_String() failed,
> just 0 will be returned but we need to return -1
> that means error status, so fix it.

Ug, I just noticed this patch floating in the flood of my INBOX.

I just applied it, and will be pushing it out soon.

Thanks, and I'm really sorry for not seeing it.

-- Steve

> 
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  plugin_python.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/plugin_python.c b/plugin_python.c
> index 2997679..c283ed7 100644
> --- a/plugin_python.c
> +++ b/plugin_python.c
> @@ -55,7 +55,7 @@ static int load_plugin(struct pevent *pevent, const char *path,
>  
>  	free(load);
>  
> -	return 0;
> +	return res ? 0 : -1;
>  }
>  
>  int PEVENT_PLUGIN_LOADER(struct pevent *pevent)