From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9067FC282DB for ; Mon, 21 Jan 2019 09:14:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BA3B2085A for ; Mon, 21 Jan 2019 09:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726058AbfAUJOC (ORCPT ); Mon, 21 Jan 2019 04:14:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:49364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbfAUJOB (ORCPT ); Mon, 21 Jan 2019 04:14:01 -0500 Received: from vmware.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 779D52084A; Mon, 21 Jan 2019 09:14:00 +0000 (UTC) Date: Mon, 21 Jan 2019 04:13:51 -0500 From: Steven Rostedt To: Tzvetomir Stoyanov Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH 6/7] trace-cmd: Refactored make_instances() and tracecmd_remove_instances() Message-ID: <20190121041351.18a4165a@vmware.local.home> In-Reply-To: <20190116191838.32127-7-tstoyanov@vmware.com> References: <20190116191838.32127-1-tstoyanov@vmware.com> <20190116191838.32127-7-tstoyanov@vmware.com> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Wed, 16 Jan 2019 21:18:37 +0200 Tzvetomir Stoyanov wrote: > --- a/tracecmd/trace-record.c > +++ b/tracecmd/trace-record.c > @@ -4260,49 +4260,57 @@ static void clear_func_filters(void) > } > } > > -static void make_instances(void) > +static void make_one_instances(struct buffer_instance *instance) > +static void tracecmd_remove_one_instance(struct buffer_instance *instance) I would just make the names non plural, and call them: make_one_instance() tracecmd_remove_instance() -- Steve