From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>,
Tzvetomir Stoyanov <tstoyanov@vmware.com>,
Yordan Karadzhov <ykaradzhov@vmware.com>
Subject: Re: [PATCH 6/8] trace-cmd: Make tracecmd_msg_send_close return error code if any
Date: Thu, 7 Feb 2019 09:41:35 -0500 [thread overview]
Message-ID: <20190207094135.6fda16e0@gandalf.local.home> (raw)
In-Reply-To: <CAE0o1Nuafu4H2fjf6oskCuCuXk-BB5y5D+Y0S-6mWfsYT9GPPw@mail.gmail.com>
On Thu, 7 Feb 2019 12:52:03 +0000
Slavomir Kaslev <kaslevs@vmware.com> wrote:
> On Tue, Feb 5, 2019 at 5:14 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Mon, 4 Feb 2019 09:08:53 +0200
> > Slavomir Kaslev <kaslevs@vmware.com> wrote:
> >
> > I accepted your patches up to here with some slight modifications to
> > the subjects and change logs. Note, when referencing function names,
> > its mostly desirable to add a "()" to the end of them to make it stand
> > out that they are functions. Like tracecmd_msg_send_close().
> >
> > But, this patch needs a change log to explain why this function should
> > return an error code. Is something going to rely on it in the future?
>
> Apologies for the empty commit message on this one, somehow it slipped
> me before sending.
>
> The intention for this patch was simply stylistic, as with close()
> which returns error code but it's seldom checked.
>
> Feel free to drop it if you find that unnecessary. Patch 7 and 8 don't
> depend on it. Should I resend them?
>
I'll drop this patch and apply the other two (after looking a bit more
at them). No need to resend.
Thanks,
-- Steve
next prev parent reply other threads:[~2019-02-07 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 7:08 [PATCH 0/8] trace-cmd protocol fixes Slavomir Kaslev
2019-02-04 7:08 ` [PATCH 1/8] trace-cmd: Remove unused global variable Slavomir Kaslev
2019-02-04 7:08 ` [PATCH 2/8] trace-cmd: Rename error_operation_for_server Slavomir Kaslev
2019-02-04 7:08 ` [PATCH 3/8] trace-cmd: Remove tracecmd_msg_handle/tracecmd_msg_server distinction Slavomir Kaslev
2019-02-04 7:08 ` [PATCH 4/8] trace-cmd: Check if connection is done when reading data in tracecmd_msg_read_data Slavomir Kaslev
2019-02-04 7:08 ` [PATCH 5/8] trace-cmd: Fix a memory leak in tracecmd_msg_send_init_data Slavomir Kaslev
2019-02-04 7:08 ` [PATCH 6/8] trace-cmd: Make tracecmd_msg_send_close return error code if any Slavomir Kaslev
2019-02-05 15:14 ` Steven Rostedt
2019-02-07 12:52 ` Slavomir Kaslev
2019-02-07 14:41 ` Steven Rostedt [this message]
2019-02-08 19:34 ` Steven Rostedt
2019-02-04 7:08 ` [PATCH 7/8] trace-cmd: Add tracecmd_msg_wait_close function Slavomir Kaslev
2019-02-04 7:08 ` [PATCH 8/8] trace-cmd: Acknowledge unexpected protocol messages Slavomir Kaslev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207094135.6fda16e0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tstoyanov@vmware.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).