From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85FD4C169C4 for ; Fri, 8 Feb 2019 13:49:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6196320869 for ; Fri, 8 Feb 2019 13:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727393AbfBHNtd (ORCPT ); Fri, 8 Feb 2019 08:49:33 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:40705 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727021AbfBHNtd (ORCPT ); Fri, 8 Feb 2019 08:49:33 -0500 Received: by mail-wm1-f67.google.com with SMTP id q21so3444330wmc.5 for ; Fri, 08 Feb 2019 05:49:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=43RRLrGurzMDe+UN5A++OKdXiNYH2gg1K52UFLPppAA=; b=gzSe0K8rQ53xk9gWj63b6BM6iZD6nssnZ0v7cAq/nDdEvHG6MSRYLtytzuxvBhv7se cp8diviDApXt5+K6slOPWoReZ1jabJQ/XvRC1su9RL85beG08yexZJcPRFYIoMffSKFx 3MYGBKj/1irBHIW+mg+bwkLo1O6vNwSAfPXNiT3slVA+BNvqgh0TBMPkx43RHH1RGXLK ejICUE1MHhLXCZWMw6y6GfuxtCEAuLCwxRm6EOat0r5imgcgCKsdx69srnr5TPuarERx EvK0To82X+ktoW23LfoLjtWBh1DfNJq0Wpo6Q8ZkdGNzq4CWQF6tzCBLVbz0FOPxNpdX XuMA== X-Gm-Message-State: AHQUAuakKPOxkYeYIAr9dEJDXHxs+roSsTQ6qbHTVs0jPxtZlJWxAllb laFPvLjQBM4NuNSKSKd+3YjuOlgw X-Google-Smtp-Source: AHgI3IbgokttoLU+syEiYK+DUdiVg7cenN1P8bUhLgQy0owVgsR/SWwuJOs837K11eqd0yax2OZ5Ww== X-Received: by 2002:a1c:c008:: with SMTP id q8mr10624882wmf.99.1549633770179; Fri, 08 Feb 2019 05:49:30 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id a184sm2534796wmh.37.2019.02.08.05.49.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Feb 2019 05:49:29 -0800 (PST) From: Tzvetomir Stoyanov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v3 6/7] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Date: Fri, 8 Feb 2019 15:49:17 +0200 Message-Id: <20190208134918.5618-7-tstoyanov@vmware.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190208134918.5618-1-tstoyanov@vmware.com> References: <20190208134918.5618-1-tstoyanov@vmware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org In order to match host and guest events, a mapping between guest VCPU and the host task, running this VCPU is needed. Extended existing struct guest to hold such mapping and added logic in read_qemu_guests() function to initialize it. Implemented a new internal API, get_guest_vcpu_pids(), to retrieve VCPU-task mapping for given VM. Signed-off-by: Tzvetomir Stoyanov --- tracecmd/include/trace-local.h | 3 ++ tracecmd/trace-record.c | 57 +++++++++++++++++++++++++++++++++- 2 files changed, 59 insertions(+), 1 deletion(-) diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h index 8bf7c8e..4f6e239 100644 --- a/tracecmd/include/trace-local.h +++ b/tracecmd/include/trace-local.h @@ -233,6 +233,9 @@ void show_instance_file(struct buffer_instance *instance, const char *name); int count_cpus(void); +#define VCPUS_MAX 256 +int *get_guest_vcpu_pids(int cid); + /* No longer in event-utils.h */ void __noreturn die(const char *fmt, ...); /* Can be overriden */ void *malloc_or_die(unsigned int size); /* Can be overridden */ diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index e1ad797..ab3f97e 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -2754,6 +2754,7 @@ struct guest { char *name; int cid; int pid; + int cpu_pid[VCPUS_MAX]; }; static struct guest *guests; @@ -2774,9 +2775,10 @@ static char *get_qemu_guest_name(char *arg) static void read_qemu_guests(void) { static bool initialized; + struct dirent *entry_t; struct dirent *entry; char path[PATH_MAX]; - DIR *dir; + DIR *dir, *dir_t; if (initialized) return; @@ -2832,6 +2834,49 @@ static void read_qemu_guests(void) if (!is_qemu) goto next; + snprintf(path, sizeof(path), "/proc/%s/task", entry->d_name); + dir_t = opendir(path); + if (dir_t) { + unsigned int vcpu; + char *buf = NULL; + char *cpu_str; + FILE *ft; + size_t n; + int j; + + for (entry_t = readdir(dir_t); entry_t; entry_t = readdir(dir_t)) { + if (!(entry_t->d_type == DT_DIR && + is_digits(entry_t->d_name))) + continue; + snprintf(path, sizeof(path), + "/proc/%s/task/%s/comm", + entry->d_name, entry_t->d_name); + ft = fopen(path, "r"); + if (!ft) + continue; + getline(&buf, &n, ft); + if (buf && strncmp(buf, "CPU ", 4) == 0) { + cpu_str = buf; + while (*cpu_str != '\0' && + isdigit(*cpu_str) == 0) + cpu_str++; + if (*cpu_str != '\0') { + j = 0; + while (cpu_str[j] != '\0' && + isdigit(cpu_str[j]) != 0) + j++; + cpu_str[j] = '\0'; + vcpu = atoi(cpu_str); + if (vcpu < VCPUS_MAX) + guest.cpu_pid[vcpu] = atoi(entry_t->d_name); + } + } + free(buf); + fclose(ft); + buf = NULL; + } + } + guests = realloc(guests, (guests_len + 1) * sizeof(*guests)); if (!guests) die("Can not allocate guest buffer"); @@ -2877,6 +2922,16 @@ static char *parse_guest_name(char *guest, int *cid, int *port) return guest; } +int *get_guest_vcpu_pids(int cid) +{ + int i; + + for (i = 0; i < guests_len; i++) + if (cid == guests[i].cid) + return guests[i].cpu_pid; + return NULL; +} + static void set_prio(int prio) { struct sched_param sp; -- 2.20.1