From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] trace-cmd: Refactored make_instances() and tracecmd_remove_instances()
Date: Fri, 8 Feb 2019 17:44:09 -0500 [thread overview]
Message-ID: <20190208174409.74df79a3@gandalf.local.home> (raw)
In-Reply-To: <20190208134918.5618-6-tstoyanov@vmware.com>
On Fri, 8 Feb 2019 15:49:16 +0200
Tzvetomir Stoyanov <tstoyanov@vmware.com> wrote:
> +static void tracecmd_remove_one_instance(struct buffer_instance *instance)
> +{
> + char *path;
> +
> + if (instance->tracing_on_fd > 0) {
> + close(instance->tracing_on_fd);
> + instance->tracing_on_fd = 0;
Also note that uninitialized file descriptors should be a negative
number (-1), because zero is a valid descriptor value.
-- Steve
> }
> + path = get_instance_dir(instance);
> + tracecmd_put_tracing_file(path);
> }
>
next prev parent reply other threads:[~2019-02-08 22:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 13:49 [PATCH v3 0/7][POC] trace-cmd: Timetamps sync using PTP-like algorithm, relying on vsock events Tzvetomir Stoyanov
2019-02-08 13:49 ` [PATCH v3 1/7] trace-cmd: Implemented new lib API: tracecmd_local_events_system() Tzvetomir Stoyanov
2019-02-08 13:49 ` [PATCH v3 2/7] trace-cmd: Added support for negative time offsets in trace.dat file Tzvetomir Stoyanov
2019-02-08 21:39 ` Steven Rostedt
2019-02-08 13:49 ` [PATCH v3 3/7] trace-cmd: Fixed logic in tracecmd_read_page_record() Tzvetomir Stoyanov
2019-02-08 22:08 ` Steven Rostedt
2019-02-08 13:49 ` [PATCH v3 4/7] trace-cmd: Added implementation of htonll() and ntohll() Tzvetomir Stoyanov
2019-02-08 13:49 ` [PATCH v3 5/7] trace-cmd: Refactored make_instances() and tracecmd_remove_instances() Tzvetomir Stoyanov
2019-02-08 22:11 ` Steven Rostedt
2019-02-08 22:44 ` Steven Rostedt [this message]
2019-02-08 22:46 ` Steven Rostedt
2019-02-08 13:49 ` [PATCH v3 6/7] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Tzvetomir Stoyanov
2019-02-08 13:49 ` [PATCH v3 7/7] trace-cmd [POC]: Implemented timestamps synch PTP-like algorithm, using vsock events Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208174409.74df79a3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).