From: Slavomir Kaslev <kaslevs@vmware.com>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: rostedt@goodmis.org, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] kernel-shark: sched_events plugin init with sched_switch events only
Date: Tue, 5 Mar 2019 17:57:55 +0200 [thread overview]
Message-ID: <20190305155754.GC19674@box> (raw)
In-Reply-To: <20190305143924.11056-4-ykaradzhov@vmware.com>
On Tue, Mar 05, 2019 at 04:39:24PM +0200, Yordan Karadzhov wrote:
> The sched_events plugin should not be totally disabled when the
> wakeup events are missing. The initialization of the plugin must
> fail only if the trace.dat file contains no sched_switch events.
>
> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
> ---
> kernel-shark/src/plugins/sched_events.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel-shark/src/plugins/sched_events.c b/kernel-shark/src/plugins/sched_events.c
> index fe13e6a..c52fb29 100644
> --- a/kernel-shark/src/plugins/sched_events.c
> +++ b/kernel-shark/src/plugins/sched_events.c
> @@ -104,9 +104,6 @@ static bool plugin_sched_init_context(struct kshark_context *kshark_ctx)
> &plugin_ctx->sched_waking_event,
> &plugin_ctx->sched_waking_pid_field);
>
> - if (!wakeup_found)
> - return false;
> -
> plugin_ctx->second_pass_hash = tracecmd_filter_id_hash_alloc();
>
> return true;
Looks good to me.
Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>
Thank you,
-- Slavi
next prev parent reply other threads:[~2019-03-05 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 14:39 [PATCH 0/3] Improvements and fixes for sched_switch plugin Yordan Karadzhov
2019-03-05 14:39 ` [PATCH 1/3] kernel-shark: Define free_contex function for the sched_events plugin Yordan Karadzhov
2019-03-05 15:54 ` Slavomir Kaslev
2019-03-05 17:11 ` Steven Rostedt
2019-03-05 14:39 ` [PATCH 2/3] kernel-shark: Fix a memory leak in " Yordan Karadzhov
2019-03-05 15:56 ` Slavomir Kaslev
2019-03-05 17:12 ` Steven Rostedt
2019-03-05 17:07 ` Steven Rostedt
2019-03-05 14:39 ` [PATCH 3/3] kernel-shark: sched_events plugin init with sched_switch events only Yordan Karadzhov
2019-03-05 15:57 ` Slavomir Kaslev [this message]
2019-03-05 17:13 ` Steven Rostedt
2019-03-05 17:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305155754.GC19674@box \
--to=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).