From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAFB7C43381 for ; Wed, 13 Mar 2019 16:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 860C6213A2 for ; Wed, 13 Mar 2019 16:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725895AbfCMQ7g (ORCPT ); Wed, 13 Mar 2019 12:59:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:38976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbfCMQ7g (ORCPT ); Wed, 13 Mar 2019 12:59:36 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 668712077B; Wed, 13 Mar 2019 16:59:35 +0000 (UTC) Date: Wed, 13 Mar 2019 12:59:34 -0400 From: Steven Rostedt To: Tzvetomir Stoyanov Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v4 15/46] tools/lib/traceevent: Man pages for tep_register_function() and tep_register_print_string() Message-ID: <20190313125934.339ee18c@gandalf.local.home> In-Reply-To: <20190308133654.21264-16-tstoyanov@vmware.com> References: <20190308133654.21264-1-tstoyanov@vmware.com> <20190308133654.21264-16-tstoyanov@vmware.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Fri, 8 Mar 2019 15:36:23 +0200 Tzvetomir Stoyanov wrote: > +EXAMPLE > +------- > +[source,c] > +-- > +#include > +... > +struct tep_handle *tep = tep_alloc(); > +... > + if (tep_register_function(tep, "my_custom_func", > + (unsigned long long) 0x12345678, NULL) != 0) { There's a whitespace bug in the above string. Also, I wouldn't use "my_custom_func" as the example name, as its not for custom names. I would use "kernel_function_X" or something similar. -- Steve > + /* Failed to register my_custom_func address mapping */ > + } > +... > + if (tep_register_print_string(tep, "print string", > + (unsigned long long) 0x87654321, NULL) != 0) { > + /* Failed to register "print string" address mapping */ > + } > +--