From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197B4C43381 for ; Fri, 15 Mar 2019 00:05:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1A3B21873 for ; Fri, 15 Mar 2019 00:05:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727642AbfCOAFl (ORCPT ); Thu, 14 Mar 2019 20:05:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:50918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726843AbfCOAFl (ORCPT ); Thu, 14 Mar 2019 20:05:41 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C189C21872; Fri, 15 Mar 2019 00:05:40 +0000 (UTC) Date: Thu, 14 Mar 2019 20:05:39 -0400 From: Steven Rostedt To: Yordan Karadzhov Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v2 6/6] kernel-shark-qt: Fix bug in plugin actions execution Message-ID: <20190314200539.7bfd90e2@gandalf.local.home> In-Reply-To: <20190314200114.4c5abf5b@gandalf.local.home> References: <20190109130945.28519-1-ykaradzhov@vmware.com> <20190109130945.28519-7-ykaradzhov@vmware.com> <20190109115253.70c0bc18@gandalf.local.home> <20190314200114.4c5abf5b@gandalf.local.home> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 14 Mar 2019 20:01:14 -0400 Steven Rostedt wrote: > Ping? Actually this is marked as superseded in patchwork. Is it? -- Steve > > On Wed, 9 Jan 2019 11:52:53 -0500 > Steven Rostedt wrote: > > > On Wed, 9 Jan 2019 15:09:45 +0200 > > Yordan Karadzhov wrote: > > > > > Plugin-provided actions are executed when loading the data. These > > > actions can be used to modify the contain of the kshark_entries > > > > "modify the contain of" ? > > > > > generated by a given event type and we consider the case of having > > > more than one plugin-provided actions per event type. However, the code > > > > "more than one plugin-provided actions per event type." also doesn't > > make sense. > > > > > that handles the case of multiple actions per-event has a bug. The "if" > > > was introduced with the idea that only the last per-event action will > > > modify the KS_PLUGIN_UNTOUCHED flag of the entry, but it misbehaves in > > > the case of a single per-event action in the list, followed by actions > > > for other events. > > > > Patch looks fine, but can you resend with a cleaner change log? > > > > Thanks! > > > > -- Steve > > > > > > > > Signed-off-by: Yordan Karadzhov > > > --- > > > kernel-shark-qt/src/libkshark.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/kernel-shark-qt/src/libkshark.c b/kernel-shark-qt/src/libkshark.c > > > index 598ea52..9ab2d57 100644 > > > --- a/kernel-shark-qt/src/libkshark.c > > > +++ b/kernel-shark-qt/src/libkshark.c > > > @@ -750,8 +750,7 @@ static size_t get_records(struct kshark_context *kshark_ctx, > > > entry->event_id))) { > > > evt_handler->event_func(kshark_ctx, rec, entry); > > > evt_handler = evt_handler->next; > > > - if (!evt_handler) > > > - entry->visible &= ~KS_PLUGIN_UNTOUCHED_MASK; > > > + entry->visible &= ~KS_PLUGIN_UNTOUCHED_MASK; > > > } > > > > > > pid = entry->pid; > >