linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <slavomir.kaslev@gmail.com>
Cc: Yordan Karadzhov <ykaradzhov@vmware.com>,
	linux-trace-devel@vger.kernel.org,
	"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: Re: [PATCH v2 1/8] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark
Date: Fri, 19 Apr 2019 14:18:52 -0400	[thread overview]
Message-ID: <20190419141852.51c98960@gandalf.local.home> (raw)
In-Reply-To: <CAE0o1NtWOkUWvmsc+RtJjM8LdD1Fp8C8wEir-WPj2GCxUhz+8Q@mail.gmail.com>

On Fri, 19 Apr 2019 10:19:38 +0300
Slavomir Kaslev <slavomir.kaslev@gmail.com> wrote:

> Nit: s/QString(getpwuid(getuid())->pw_dir)/QDir::homePath()/
> 
> Everything else looks great with the patch
> Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>

Yordan,

If someone gives you a review by, please add it to the next revision, if
you didn't change the patch. And if you do change it, ask for a new
review-by.

Thanks!

-- Steve

  reply	other threads:[~2019-04-19 18:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 15:21 [PATCH v2 0/8] Various modifications and fixes toward KS 1.0 Yordan Karadzhov
2019-04-18 15:21 ` [PATCH v2 1/8] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark Yordan Karadzhov
2019-04-19  7:19   ` Slavomir Kaslev
2019-04-19 18:18     ` Steven Rostedt [this message]
2019-04-18 15:21 ` [PATCH v2 2/8] kernel-shark: Remove the definition of KS_CONF_DIR Yordan Karadzhov
2019-04-18 15:21 ` [PATCH v2 3/8] kernel-shark: Add logic for the initial path of Open-File dialogs Yordan Karadzhov
2019-04-19  7:26   ` Slavomir Kaslev
2019-04-19 17:48     ` Steven Rostedt
2019-04-18 15:21 ` [PATCH v2 4/8] kernel-shark: Add logic for the plugins search path Yordan Karadzhov
2019-04-19  7:43   ` Slavomir Kaslev
2019-04-19 17:59     ` Steven Rostedt
2019-04-18 15:21 ` [PATCH v2 5/8] kernel-shark: Rename KS_DIR to KS_SOURCE_DIR Yordan Karadzhov
2019-04-18 15:21 ` [PATCH v2 6/8] kernel-shark: Load Last Session from command line Yordan Karadzhov
2019-04-18 15:21 ` [PATCH v2 7/8] kernel-shark: Use proper searching condition when the dataset is small Yordan Karadzhov
2019-04-18 15:21 ` [PATCH v2 8/8] kernel-shark: Handle the case when the marker points to a filtered entry Yordan Karadzhov
2019-04-19  7:29   ` Slavomir Kaslev
2019-04-19  7:46     ` Yordan Karadzhov
2019-04-19  7:55       ` Slavomir Kaslev
2019-04-19  8:07       ` Slavomir Kaslev
2019-04-19 18:03       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419141852.51c98960@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=slavomir.kaslev@gmail.com \
    --cc=y.karadz@gmail.com \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).