From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org, y.karadz@gmail.com,
Yordan Karadzhov <ykaradzhov@vmware.com>,
Slavomir Kaslev <kaslevs@vmware.com>
Subject: [PATCH 4/6] kernel-shark: Add "Report bug" button to "Help"
Date: Wed, 15 May 2019 12:09:09 -0700 [thread overview]
Message-ID: <20190515190911.20755-5-ykaradzhov@vmware.com> (raw)
In-Reply-To: <20190515190911.20755-1-ykaradzhov@vmware.com>
When clicked, the Bugzilla will be opened in the appropriate Web browser
for the user's desktop environment.
Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>
Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
---
kernel-shark/src/KsMainWindow.cpp | 13 +++++++++++++
kernel-shark/src/KsMainWindow.hpp | 4 ++++
2 files changed, 17 insertions(+)
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index 3cf10bc..c7c7f6b 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -67,6 +67,7 @@ KsMainWindow::KsMainWindow(QWidget *parent)
_fullScreenModeAction("Full Screen Mode", this),
_aboutAction("About", this),
_contentsAction("Contents", this),
+ _bugReportAction("Report a bug", this),
_deselectShortcut(this),
_settings("kernelshark.org", "Kernel Shark") // organization , application
{
@@ -288,6 +289,9 @@ void KsMainWindow::_createActions()
_contentsAction.setIcon(QIcon::fromTheme("help-contents"));
connect(&_contentsAction, &QAction::triggered,
this, &KsMainWindow::_contents);
+
+ connect(&_bugReportAction, &QAction::triggered,
+ this, &KsMainWindow::_bugReport);
}
void KsMainWindow::_createMenus()
@@ -365,6 +369,7 @@ void KsMainWindow::_createMenus()
help = menuBar()->addMenu("Help");
help->addAction(&_aboutAction);
help->addAction(&_contentsAction);
+ help->addAction(&_bugReportAction);
}
void KsMainWindow::_open()
@@ -925,6 +930,14 @@ void KsMainWindow::_contents()
QUrl::TolerantMode));
}
+void KsMainWindow::_bugReport()
+{
+ QUrl bugs("https://bugzilla.kernel.org/buglist.cgi?component=Trace-cmd%2FKernelshark&product=Tools&resolution=---",
+ QUrl::TolerantMode);
+
+ QDesktopServices::openUrl(bugs);
+}
+
/** Load trace data for file. */
void KsMainWindow::loadDataFile(const QString& fileName)
{
diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp
index 962de2d..22700d9 100644
--- a/kernel-shark/src/KsMainWindow.hpp
+++ b/kernel-shark/src/KsMainWindow.hpp
@@ -151,6 +151,8 @@ private:
QAction _contentsAction;
+ QAction _bugReportAction;
+
QShortcut _deselectShortcut;
QString _lastDataFilePath, _lastConfFilePath, _lastPluginFilePath;
@@ -205,6 +207,8 @@ private:
void _contents();
+ void _bugReport();
+
void _captureStarted();
void _captureError(QProcess::ProcessError error);
--
2.20.1
next prev parent reply other threads:[~2019-05-15 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 19:09 [PATCH 0/6] Various modifications and fixes toward KS 1.0 Yordan Karadzhov
2019-05-15 19:09 ` [PATCH 1/6] kernel-shark: Remove hard-coded install paths Yordan Karadzhov
2019-05-15 19:09 ` [PATCH 2/6] kernel-shark: Use XDG compliant path when saving cached data Yordan Karadzhov
2019-05-15 19:09 ` [PATCH 3/6] kernel-shark: Enforce update of the OpenGL widget when loading new session Yordan Karadzhov
2019-05-15 19:09 ` Yordan Karadzhov [this message]
2019-05-15 19:09 ` [PATCH 5/6] kernel-shark: Improve the appearance on high screen resolution Yordan Karadzhov
2019-05-15 19:09 ` [PATCH 6/6] kernel-shark: Handle the case when the marker points to a filtered entry Yordan Karadzhov
2019-05-16 13:42 ` [PATCH 0/6] Various modifications and fixes toward KS 1.0 Slavomir Kaslev
2019-05-21 13:59 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515190911.20755-5-ykaradzhov@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).