From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org, y.karadz@gmail.com,
Yordan Karadzhov <ykaradzhov@vmware.com>
Subject: [PATCH 2/2] kernel-shark: Fix a bug in ksmodel_set_next_bin_edge() part III
Date: Wed, 12 Jun 2019 17:20:53 +0300 [thread overview]
Message-ID: <20190612142053.14439-2-ykaradzhov@vmware.com> (raw)
In-Reply-To: <20190612142053.14439-1-ykaradzhov@vmware.com>
All time stamps of the trace records are coded with 64 bits, however
on some systems the size_t type can be 32 bits.
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
---
kernel-shark/src/libkshark-model.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel-shark/src/libkshark-model.c b/kernel-shark/src/libkshark-model.c
index 0cac924..dde64de 100644
--- a/kernel-shark/src/libkshark-model.c
+++ b/kernel-shark/src/libkshark-model.c
@@ -260,7 +260,8 @@ static size_t ksmodel_set_upper_edge(struct kshark_trace_histo *histo)
static void ksmodel_set_next_bin_edge(struct kshark_trace_histo *histo,
size_t bin, size_t last_row)
{
- size_t time_min, time_max, next_bin = bin + 1;
+ uint64_t time_min, time_max;
+ size_t next_bin = bin + 1;
ssize_t row;
/* Calculate the beginning and the end of the next bin. */
--
2.20.1
next prev parent reply other threads:[~2019-06-12 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 14:20 [PATCH 1/2] kernel-shark: Fix a bug in ksmodel_set_next_bin_edge() part II Yordan Karadzhov
2019-06-12 14:20 ` Yordan Karadzhov [this message]
2019-06-12 14:28 ` Steven Rostedt
2019-06-12 14:34 ` Yordan Karadzhov
2019-06-12 14:48 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612142053.14439-2-ykaradzhov@vmware.com \
--to=ykaradzhov@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).