Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: "slavomir.kaslev@gmail.com" <slavomir.kaslev@gmail.com>,
	"linux-trace-devel@vger.kernel.org" 
	<linux-trace-devel@vger.kernel.org>,
	Tzvetomir Stoyanov <tstoyanov@vmware.com>
Subject: Re: [PATCH 0/3] trace-cmd: Fix some bugs that include issues with --max-graph-depth
Date: Thu, 13 Jun 2019 10:56:40 -0400
Message-ID: <20190613105640.1f9b9d44@gandalf.local.home> (raw)
In-Reply-To: <CAE0o1NuCo-vhX9j6G_OnYi=UwMETv+eH=881z1oryzJ_6=JKuQ@mail.gmail.com>

On Thu, 13 Jun 2019 14:51:48 +0000
Slavomir Kaslev <kaslevs@vmware.com> wrote:

> On Wed, Jun 12, 2019 at 9:21 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >
> > Some last minute bugs that were found and fixed.
> >
> > Steven Rostedt (VMware) (3):
> >       trace-cmd: Fix typo in Makefile bidr to bdir
> >       trace-cmd: Have --max-graph-depth only be part of instance
> >       trace-cmd: Check the return of get_file_content() before calling add_reset_file()
> >
> > ----
> >  tracecmd/Makefile              |  2 +-
> >  tracecmd/include/trace-local.h |  2 ++
> >  tracecmd/trace-record.c        | 33 +++++++++++++++++++--------------
> >  3 files changed, 22 insertions(+), 15 deletions(-)  
> 
> Looks good to me.
> 
> Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>
> 

Thanks Slavomir and Tzvetomir.

I'll add these patches now with both of your reviewed-bys.

-- Steve

      reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 18:19 Steven Rostedt
2019-06-12 18:19 ` [PATCH 1/3] trace-cmd: Fix typo in Makefile bidr to bdir Steven Rostedt
2019-06-13 14:40   ` Tzvetomir Stoyanov
2019-06-12 18:19 ` [PATCH 2/3] trace-cmd: Have --max-graph-depth only be part of instance Steven Rostedt
2019-06-13 14:48   ` Tzvetomir Stoyanov
2019-06-12 18:19 ` [PATCH 3/3] trace-cmd: Check the return of get_file_content() before calling add_reset_file() Steven Rostedt
2019-06-13 14:51   ` Tzvetomir Stoyanov
2019-06-13 14:51 ` [PATCH 0/3] trace-cmd: Fix some bugs that include issues with --max-graph-depth Slavomir Kaslev
2019-06-13 14:56   ` Steven Rostedt [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190613105640.1f9b9d44@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=kaslevs@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=slavomir.kaslev@gmail.com \
    --cc=tstoyanov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org linux-trace-devel@archiver.kernel.org
	public-inbox-index linux-trace-devel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox