From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 6/8] kernel-shark: remove the "make install" suggestion for capture errors
Date: Tue, 9 Jul 2019 21:36:17 -0400 [thread overview]
Message-ID: <20190709213617.30fb014b@gandalf.local.home> (raw)
In-Reply-To: <20190709155650.2345-7-y.karadz@gmail.com>
On Tue, 9 Jul 2019 18:56:48 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> The message is not appropriate, although it is most likely that the
> error occurs because the user didn't install KernelShark and it runs
> the executable from its build location.=
I don't believe it is most likely, as I hit this error several times and
that wasn't the solution.
But we need to have an error stating what was missing.
-- Steve
>
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
> kernel-shark/src/KsMainWindow.cpp | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
> index 752a17a..3f238db 100644
> --- a/kernel-shark/src/KsMainWindow.cpp
> +++ b/kernel-shark/src/KsMainWindow.cpp
> @@ -1154,8 +1154,6 @@ void KsMainWindow::_captureError(QProcess::ProcessError error)
> QString message = "Capture process failed:<br>";
>
> message += capture->errorString();
> - message += "<br>Try doing:<br> sudo make install";
> -
> _error(message, "captureFinishedErr", false, false);
> }
>
next prev parent reply other threads:[~2019-07-10 1:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 15:56 [PATCH 0/8]Fixes needed befor KS 1.0 Yordan Karadzhov (VMware)
2019-07-09 15:56 ` [PATCH 1/8] kernel-shark: Don't free the string field of KS_CONFIG_STRING document Yordan Karadzhov (VMware)
2019-07-09 15:56 ` [PATCH 2/8] kernel-shark: Add method for getting all selected events Yordan Karadzhov (VMware)
2019-07-09 15:56 ` [PATCH 3/8] kernel-shark: Optimize the command line options used by the capture dialog Yordan Karadzhov (VMware)
2019-07-09 15:56 ` [PATCH 4/8] kernel-shark: Don't try to open data file if recording failed Yordan Karadzhov (VMware)
2019-07-09 15:56 ` [PATCH 5/8] kernel-shark: Remove a duplicate error message Yordan Karadzhov (VMware)
2019-07-09 15:56 ` [PATCH 6/8] kernel-shark: remove the "make install" suggestion for capture errors Yordan Karadzhov (VMware)
2019-07-10 1:36 ` Steven Rostedt [this message]
2019-07-09 15:56 ` [PATCH 7/8] kernel-shark: Disconnect "capture errors" before closing KernelShark GUI Yordan Karadzhov (VMware)
2019-07-09 15:56 ` [PATCH 8/8] kernel-shark: Less scary error message from Capture dialog Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709213617.30fb014b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).