From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 3/3] kernel-shark: Don't try to update the markers if no data is loaded
Date: Mon, 15 Jul 2019 16:20:42 +0300 [thread overview]
Message-ID: <20190715132042.5154-4-y.karadz@gmail.com> (raw)
In-Reply-To: <20190715132042.5154-1-y.karadz@gmail.com>
This change aims to avoid showing the labels of the time axis (zeros)
when no data is loaded.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
kernel-shark/src/KsMainWindow.cpp | 18 ++++++++++++------
kernel-shark/src/KsMainWindow.hpp | 2 ++
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index 8826cf5..c8d9d25 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -1210,12 +1210,20 @@ void KsMainWindow::_splitterMoved(int pos, int index)
_session.saveSplitterSize(_splitter);
}
+void KsMainWindow::_updateMarkData()
+{
+ if (_data.size() < 1)
+ return;
+
+ _mState.updateLabels();
+ _graph.glPtr()->model()->update();
+}
+
void KsMainWindow::_deselectActive()
{
_view.clearSelection();
_mState.activeMarker().remove();
- _mState.updateLabels();
- _graph.glPtr()->model()->update();
+ _updateMarkData();
}
void KsMainWindow::_deselectA()
@@ -1226,8 +1234,7 @@ void KsMainWindow::_deselectA()
_view.passiveMarkerSelectRow(KS_NO_ROW_SELECTED);
_mState.markerA().remove();
- _mState.updateLabels();
- _graph.glPtr()->model()->update();
+ _updateMarkData();
}
void KsMainWindow::_deselectB()
@@ -1238,6 +1245,5 @@ void KsMainWindow::_deselectB()
_view.passiveMarkerSelectRow(KS_NO_ROW_SELECTED);
_mState.markerB().remove();
- _mState.updateLabels();
- _graph.glPtr()->model()->update();
+ _updateMarkData();
}
diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp
index 62e66a0..7e2e839 100644
--- a/kernel-shark/src/KsMainWindow.hpp
+++ b/kernel-shark/src/KsMainWindow.hpp
@@ -232,6 +232,8 @@ private:
void _error(const QString &text, const QString &errCode,
bool resize, bool unloadPlugins);
+ void _updateMarkData();
+
void _deselectActive();
void _deselectA();
--
2.20.1
next prev parent reply other threads:[~2019-07-15 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 13:20 [PATCH 0/3] Fixes needed befor KS 1.0 Yordan Karadzhov (VMware)
2019-07-15 13:20 ` [PATCH 1/3] kernel-shark: The graph widget must follow the active marker Yordan Karadzhov (VMware)
2019-07-15 13:20 ` [PATCH 2/3] kernel-shark: Always clear the marker after resizing the table Yordan Karadzhov (VMware)
2019-07-15 13:20 ` Yordan Karadzhov (VMware) [this message]
2019-07-17 19:30 ` [PATCH 3/3] kernel-shark: Don't try to update the markers if no data is loaded Steven Rostedt
2019-07-18 13:51 ` Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715132042.5154-4-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).