linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Changes in few libtraceevent APIs
Date: Tue, 30 Jul 2019 16:06:02 -0400	[thread overview]
Message-ID: <20190730160602.15ed9b20@gandalf.local.home> (raw)
In-Reply-To: <20190730125028.24789-1-tz.stoyanov@gmail.com>

On Tue, 30 Jul 2019 15:50:25 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:

> Before releasing libtraceevent as a standalone library, few
> APIs must be changed:
>  - Event printing interface is redesigned, to be more simple
>    and user friendly. Now the tep_print_event() API can be used 
>    to print various event information. All other event print APIs
>    are removed.
>  - Changed the user's plugin directory to 
>    ~/.local/lib/traceevent/plugins/ to be XDG compliant.

BTW, the other two patches look good. Let's send a v2 of all the
patches with the comments in the first patch addressed.

Thanks Ceco!

-- Steve


> 
> [
>  v2 canges:
>   - the user's plugin directory changed from 
>  ~/.config/traceevent/plugins/ to ~/.local/lib/traceevent/plugins/, 
>  as suggested by Patrick McLean.
> ]
> 
> Tzvetomir Stoyanov (3):
>   tools/lib/traceevent, tools/perf: Changes in tep_print_event_* APIs
>   tools/lib/traceevent: Remove tep_register_trace_clock()
>   tools/lib/traceevent: Change user's plugin directory
> 
>  tools/lib/traceevent/Makefile            |   6 +-
>  tools/lib/traceevent/event-parse-api.c   |  40 ---
>  tools/lib/traceevent/event-parse-local.h |   6 -
>  tools/lib/traceevent/event-parse.c       | 308 +++++++++++++----------
>  tools/lib/traceevent/event-parse.h       |  29 +--
>  tools/lib/traceevent/event-plugin.c      |   2 +-
>  tools/perf/builtin-kmem.c                |   3 +-
>  tools/perf/util/sort.c                   |   3 +-
>  tools/perf/util/trace-event-parse.c      |   2 +-
>  9 files changed, 197 insertions(+), 202 deletions(-)
> 


      parent reply	other threads:[~2019-07-30 20:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 12:50 [PATCH v2 0/3] Changes in few libtraceevent APIs Tzvetomir Stoyanov (VMware)
2019-07-30 12:50 ` [PATCH v2 1/3] tools/lib/traceevent, tools/perf: Changes in tep_print_event_* APIs Tzvetomir Stoyanov (VMware)
2019-07-30 16:12   ` Steven Rostedt
2019-07-31 12:16     ` Tzvetomir Stoyanov
2019-07-31 12:27       ` Steven Rostedt
2019-07-30 12:50 ` [PATCH v2 2/3] tools/lib/traceevent: Remove tep_register_trace_clock() Tzvetomir Stoyanov (VMware)
2019-07-30 12:50 ` [PATCH v2 3/3] tools/lib/traceevent: Change user's plugin directory Tzvetomir Stoyanov (VMware)
2019-07-30 20:06 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730160602.15ed9b20@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).