linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Patrick McLean <chutzpah@gentoo.org>,
	Tzvetomir Stoyanov <tstoyanov@vmware.com>
Subject: [PATCH 0/3] tools lib traceevent: Fixing the API to be less policy driven
Date: Mon, 05 Aug 2019 16:43:12 -0400	[thread overview]
Message-ID: <20190805204312.169565525@goodmis.org> (raw)

Hi Arnaldo and Jiri,

We are still working on getting libtraceevent ready to be a stand alone
library. Part of that is to audit all the interfaces. We noticed
that the most the tep_print_*() interfaces define policy and limit
the way an application can display data. Instead of fixing this later
and being stuck with a limiting API that we must maintain for backward
compatibility, we removed and replaced most of it. perf was only affected
by a single function that was removed. These functions are replaced
by a more flexible one that allows the user to place what they want
where they want it (timestamps, event info, latency format, COMM, PID, etc).

The other noticeable perf change, is that we changed the location to
where the plugins are loaded from:

 ${HOME}/.traceevent/plugins

to

 ${HOME}/.local/lib/traceevent/plugins

As Patrick McLean (Gentoo package maintainer) informed us of the
XGD layout.

Should we have something the warns people if they have plugins in
the old directory. Should we move them on install? Currently, we
just ignore them.

Anyway, please add these patches to tip.

Thanks!

-- Steve


Tzvetomir Stoyanov (3):
      tools/lib/traceevent, tools/perf: Changes in tep_print_event_* APIs
      tools/lib/traceevent: Remove tep_register_trace_clock()
      tools/lib/traceevent: Change user's plugin directory

----
 tools/lib/traceevent/Makefile            |   6 +-
 tools/lib/traceevent/event-parse-api.c   |  40 ----
 tools/lib/traceevent/event-parse-local.h |   6 -
 tools/lib/traceevent/event-parse.c       | 333 +++++++++++++++++--------------
 tools/lib/traceevent/event-parse.h       |  30 +--
 tools/lib/traceevent/event-plugin.c      |   2 +-
 tools/perf/builtin-kmem.c                |   3 +-
 tools/perf/util/sort.c                   |   3 +-
 tools/perf/util/trace-event-parse.c      |   2 +-
 9 files changed, 207 insertions(+), 218 deletions(-)

             reply	other threads:[~2019-08-05 20:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-05 20:43 Steven Rostedt [this message]
2019-08-05 20:43 ` [PATCH 1/3] tools/lib/traceevent, tools/perf: Changes in tep_print_event_* APIs Steven Rostedt
2019-08-05 20:43 ` [PATCH 2/3] tools/lib/traceevent: Remove tep_register_trace_clock() Steven Rostedt
2019-08-05 20:43 ` [PATCH 3/3] tools/lib/traceevent: Change users plugin directory Steven Rostedt
2019-08-29 18:00 ` [PATCH 0/3] tools lib traceevent: Fixing the API to be less policy driven Steven Rostedt
2019-08-29 20:37   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190805204312.169565525@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chutzpah@gentoo.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tstoyanov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).