From: Steven Rostedt <rostedt@goodmis.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: linux-trace-devel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH 1/2] parse-events: deref pointer for proper sizeof()
Date: Mon, 5 Aug 2019 23:21:03 -0400 [thread overview]
Message-ID: <20190805232103.04c6ad28@oasis.local.home> (raw)
In-Reply-To: <20190805102646.31142-1-sergey.senozhatsky@gmail.com>
On Mon, 5 Aug 2019 19:26:45 +0900
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
Hi Sergey,
Thanks for sending these!
-- Steve
> parse-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/parse-events.c b/parse-events.c
> index 3d59d92..807fc53 100644
> --- a/parse-events.c
> +++ b/parse-events.c
> @@ -2058,7 +2058,7 @@ process_fields(struct event_format *event, struct print_flag_sym **list, char **
> goto out_free;
>
> field = malloc_or_die(sizeof(*field));
> - memset(field, 0, sizeof(field));
> + memset(field, 0, sizeof(*field));
>
> value = arg_eval(arg);
> field->value = strdup(value);
next prev parent reply other threads:[~2019-08-06 3:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 10:26 [PATCH 1/2] parse-events: deref pointer for proper sizeof() Sergey Senozhatsky
2019-08-05 10:26 ` [PATCH 2/2] " Sergey Senozhatsky
2019-08-06 3:21 ` Steven Rostedt [this message]
2019-08-06 5:14 ` [PATCH 1/2] " Sergey Senozhatsky
2019-08-06 5:41 ` Sergey Senozhatsky
2019-08-06 6:07 ` Sergey Senozhatsky
2019-08-06 12:50 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805232103.04c6ad28@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).